Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9997

Code cleanup in ZKConfigurationStore

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.2, 3.4.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Many thins can be improved:

      • znodeParentPath could be a local variable
      • zkManager could be private, VisibleForTesting annotation is not needed anymore
      • Do something with unchecked casts
      • zkManager.safeSetData calls are almost having the same set of parameters: Simplify this
      • Extract zkManager calls to their own methods: They are repeated
      • Remove TODOs

        Attachments

        1. YARN-9997.001.patch
          10 kB
          Andras Gyori
        2. YARN-9997.002.patch
          14 kB
          Andras Gyori
        3. YARN-9997.003.patch
          15 kB
          Andras Gyori
        4. YARN-9997.004.patch
          15 kB
          Andras Gyori
        5. YARN-9997.005.patch
          15 kB
          Andras Gyori
        6. YARN-9997.006.patch
          15 kB
          Andras Gyori
        7. YARN-9997.branch-3.2.001.patch
          15 kB
          Andras Gyori

          Issue Links

            Activity

              People

              • Assignee:
                gandras Andras Gyori
                Reporter:
                snemeth Szilard Nemeth
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: