[YARN-9966] Code duplication in UserGroupMappingPlacementRule

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.2.2, 3.1.4
• Labels: newbie newbie++
• Hadoop Flags: Reviewed
• Assignee: Kevin Su
• Reporter: Szilard Nemeth
• Created: 11/Nov/19 12:16
• Updated: 25/Nov/19 07:32
• Resolved: 25/Nov/19 07:07

Description

The methods org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule#validateParentQueue and org.apache.hadoop.yarn.server.resourcemanager.placement.QueuePlacementRuleUtils#validateQueueMappingUnderParentQueue are exactly the same.
In these 2 classes, we also have a duplicate method named "extractQueuePath".

We need to extract these to a common method and delete one of these dupes.

Issue Links

• links to: GitHub Pull Request #1709