Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9677

Make FpgaDevice and GpuDevice classes more similar to each other

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.fpga.FpgaResourceAllocator.FpgaDevice is an inner class of FpgaResourceAllocator.
      It is not only being used from its parent class but from other classes as well so we are losing the purpose of the inner class, it does not really make sense.

      We also have
      org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuDevice which is a similar class, but for GPU devices.

      What we could do here is to make FpgaDevice a single class and harmonize the packages of these 2 classes, meaning they should be "closer" to each other in terms of packaging.

        Attachments

        1. YARN-9677.001.patch
          34 kB
          kevin su

          Activity

            People

            • Assignee:
              pingsutw kevin su
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: