[YARN-966] The thread of ContainerLaunch#call will fail without any signal if getLocalizedResources() is called when the container is not at LOCALIZED

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.1-beta
• Hadoop Flags: Reviewed
• Assignee: Zhijie Shen
• Reporter: Zhijie Shen
• Created: 24/Jul/13 07:33
• Updated: 24/Sep/13 23:33
• Resolved: 31/Jul/13 00:34

Description

In ContainerImpl.getLocalizedResources(), there's:

assert ContainerState.LOCALIZED == getContainerState(); // TODO: FIXME!!

ContainerImpl.getLocalizedResources() is called in ContainerLaunch.call(), which is scheduled on a separate thread. If the container is not at LOCALIZED (e.g. it is at KILLING, see YARN-906), an AssertError will be thrown and fails the thread without notifying NM. Therefore, the container cannot receive more events, which are supposed to be sent from ContainerLaunch.call(), and move towards completion.

Issue Links

• relates to: YARN-906 Cancelling ContainerLaunch#call at KILLING causes that the container cannot be completed