[YARN-9533] TimelineV2ClientImpl.checkRetryWithSleep() throws a YarnException when interrupted

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Haicheng Chen
• Created: 06/May/19 16:32
• Updated: 07/May/19 14:11

Description

Dear YARN developers, we are developing a tool to detect exception-related bugs in Java. Our prototype has spotted the following throw statement whose exception class and error message indicate different error conditions. 

  

Version: Hadoop-3.1.2 

File: HADOOP-ROOT/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineV2ClientImpl.java

Line: 274

try {
  Thread.sleep(this.serviceRetryInterval);
} catch (InterruptedException ex) {
  Thread.currentThread().interrupt();
  throw new YarnException("Interrupted while retrying to connect to ATS");
}

 

The exception is triggered when checkRetryWithSleep() is interrupted. However, throwing a YarnException is too general and makes accurate exception handling more difficult. Throwing an InterruptedIOException or wrapping the InterruptedException could be more accurate here.

Issue Links

• is related to: YARN-9534 TimelineV2ClientImpl.pollTimelineServiceAddress() throws a YarnException when it is interrupted