[YARN-948] RM should validate the release container list before actually releasing them

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.1-beta
• Hadoop Flags: Reviewed
• Assignee: Omkar Vinit Joshi
• Reporter: Omkar Vinit Joshi
• Created: 22/Jul/13 21:31
• Updated: 24/Sep/13 23:33
• Resolved: 30/Jul/13 20:33

Description

At present we are blinding passing the allocate request containing containers to be released to the scheduler. This may result into one application releasing another application's container.

  @Override
  @Lock(Lock.NoLock.class)
  public Allocation allocate(ApplicationAttemptId applicationAttemptId,
      List<ResourceRequest> ask, List<ContainerId> release, 
      List<String> blacklistAdditions, List<String> blacklistRemovals) {

    FiCaSchedulerApp application = getApplication(applicationAttemptId);
....
....
    // Release containers
    for (ContainerId releasedContainerId : release) {
      RMContainer rmContainer = getRMContainer(releasedContainerId);
      if (rmContainer == null) {
         RMAuditLogger.logFailure(application.getUser(),
             AuditConstants.RELEASE_CONTAINER, 
             "Unauthorized access or invalid container", "CapacityScheduler",
             "Trying to release container not owned by app or with invalid id",
             application.getApplicationId(), releasedContainerId);
      }
      completedContainer(rmContainer,
          SchedulerUtils.createAbnormalContainerStatus(
              releasedContainerId, 
              SchedulerUtils.RELEASED_CONTAINER),
          RMContainerEventType.RELEASED);
    }

Current checks are not sufficient and we should prevent this..... thoughts?

Issue Links

• duplicates: YARN-969 Fair Scheduler should validate the release container list before actually releasing them
• is related to: YARN-969 Fair Scheduler should validate the release container list before actually releasing them