Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9354

Resources should be created with ResourceTypesTestHelper instead of TestUtils

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.2, 3.4.0
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestUtils#createResource has not identical, but very similar implementation to org.apache.hadoop.yarn.resourcetypes.ResourceTypesTestHelper#newResource.
      Since these 2 methods are doing the same essentially and ResourceTypesTestHelper is newer and used more, TestUtils#createResource should be replaced with ResourceTypesTestHelper#newResource with all occurrence.

        Attachments

        1. YARN-9354.001.patch
          15 kB
          Andras Gyori
        2. YARN-9354.002.patch
          11 kB
          Andras Gyori
        3. YARN-9354.003.patch
          11 kB
          Andras Gyori
        4. YARN-9354.004.patch
          12 kB
          Andras Gyori
        5. YARN-9354.branch-3.2.001.patch
          8 kB
          Andras Gyori
        6. YARN-9354.branch-3.2.002.patch
          12 kB
          Andras Gyori
        7. YARN-9354.branch-3.2.003.patch
          12 kB
          Andras Gyori

          Activity

            People

            • Assignee:
              gandras Andras Gyori
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: