Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9140

Code cleanup in ResourcePluginManager.initialize and in TestResourcePluginManager

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.1, 3.1.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some code cleanup is needed in ResourcePluginManager#initialize: 

      • There's a big code block that initializes resource plugins, this should be extracted to a separate method.
      • Exception handling could be simplified.

      TestResourcePluginManager minor cleanup: 

      • Not thrown exceptions could be deleted from method signatures
      • verify(obj, times(1)).<method>() calls: times(1) parameter could be deleted as it is the default if verify(obj) is invoked without the times parameter.
      • Some code exceeds the 80 character column limit.

        Attachments

        1. YARN-9140.branch-3.2.001.patch
          11 kB
          Peter Bacsko
        2. YARN-9140.branch-3.1.001.patch
          11 kB
          Peter Bacsko
        3. YARN-9140.006.patch
          17 kB
          Peter Bacsko
        4. YARN-9140.005.patch
          18 kB
          Peter Bacsko
        5. YARN-9140.004.patch
          18 kB
          Peter Bacsko
        6. YARN-9140.003.patch
          18 kB
          Peter Bacsko
        7. YARN-9140.002.patch
          17 kB
          Szilard Nemeth
        8. YARN-9140.001.patch
          17 kB
          Szilard Nemeth

          Activity

            People

            • Assignee:
              pbacsko Peter Bacsko
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: