XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Following up on findings in YARN-8962, I noticed the following issues in container-executor and main.c:

      • There seem to be some vars that are not cleaned up in container_executor:
        In run_docker else: free docker_binary
        In exec_container:
        before return INVALID_COMMAND_FILE: free docker_binary
        3x return DOCKER_EXEC_FAILED: set exit code and goto cleanup instead
        cleanup needed before exit calls?
      • In YARN-8777 we added several fprintf(stderr calls, but the convention in container-executor.c appears to be fprintf(ERRORFILE followed by fflush(ERRORFILE).
      • There are leaks in TestDockerUtil_test_add_ports_mapping_to_command_Test.
      • There are additional places where flush is not performed after writing to stderr, including main.c display_feature_disabled_message. This can result in the client not receiving the error message if the connection is closed too quickly.

        Attachments

        1. YARN-9129.001.patch
          38 kB
          Eric Yang
        2. YARN-9129.002.patch
          37 kB
          Eric Yang
        3. YARN-9129.003.patch
          37 kB
          Eric Yang

          Activity

            People

            • Assignee:
              eyang Eric Yang
              Reporter:
              billie Billie Rinaldi
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: