[YARN-9096] Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.2.1, 3.1.3
• Target Version/s: 3.3.0, 3.2.1, 3.1.3
• Hadoop Flags: Reviewed
• Assignee: Gergely Pollák
• Reporter: Szilard Nemeth
• Created: 08/Dec/18 10:35
• Updated: 09/Aug/19 08:35
• Resolved: 09/Aug/19 08:07

Description

These methods are not used concurrently, they are part of the initialization code of NM that happens from one thread.

This is the list of the call hierarchies: 

1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize

 

GpuResourcePlugin.initialize(Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu) ResourcePluginManager.initialize(Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin) NodeManager.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager)

 

 

2. GpuResourcePlugin.createResourceHandler: 

 

GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler, PrivilegedOperationExecutor) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu) ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List, Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ContainerScheduler.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler) LinuxContainerExecutor.init(Context) (org.apache.hadoop.yarn.server.nodemanager)

 

3. GpuResourcePlugin.getNodeResourceHandlerInstance: 

 

GpuResourcePlugin.getNodeResourceHandlerInstance() (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages) (org.apache.hadoop.yarn.server.nodemanager)
NodeStatusUpdaterImpl.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager)