[YARN-8744] In some cases docker kill is used to stop non-privileged containers instead of sending the signal directly

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Incomplete
• Labels: docker
• Assignee: Chandni Singh
• Reporter: Chandni Singh
• Created: 04/Sep/18 21:52
• Updated: 08/Jan/20 18:04
• Resolved: 08/Jan/20 18:04

Description

With YARN-8706, stopping docker containers was achieved by
1. parsing the user specified STOPSIGNAL via docker inspect
2. executing docker kill --signal=<STOPSIGNAL>

Quoting ebadger

Additionally, for non-privileged containers, we don't need to call docker kill. Instead, we can follow the code in handleContainerKill() and send the signal directly. I think this code could probably be combined, since at this point handleContainerKill() and handleContainerStop() will be doing the same thing. The only difference is that the STOPSIGNAL will be used for the stop.

To achieve the above, we need native code that accepts the name of the signal rather than the value (number) of the signal.

Issue Links

• is related to: YARN-8706 DelayedProcessKiller is executed for Docker containers even though docker stop sends a KILL signal after the specified grace period