Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.1
    • 3.2.0
    • yarn
    • None
    • Reviewed
    • Patch

    Description

      1. Use SLF4J
      2. Fix some checkstyle warnings
      3. Minor clean up

      Attachments

        1. YARN.8169.2.patch
          4 kB
          David Mollitor
        2. YARN-8169.1.patch
          4 kB
          David Mollitor

        Activity

          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 39s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 25m 12s trunk passed
          +1 compile 0m 37s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 42s trunk passed
          +1 shadedclient 11m 21s branch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 17s trunk passed
          +1 javadoc 0m 41s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 37s the patch passed
          +1 compile 0m 33s the patch passed
          +1 javac 0m 33s the patch passed
          +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 11m 29s patch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 24s the patch passed
          +1 javadoc 0m 45s the patch passed
                Other Tests
          +1 unit 3m 17s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          60m 11s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b
          JIRA Issue YARN-8169
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919441/YARN-8169.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux d537321e303c 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1d6e43d
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_162
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20370/testReport/
          Max. process+thread count 301 (vs. ulimit of 10000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/20370/console
          Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 39s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 25m 12s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 42s trunk passed +1 shadedclient 11m 21s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 17s trunk passed +1 javadoc 0m 41s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 11m 29s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 45s the patch passed       Other Tests +1 unit 3m 17s hadoop-yarn-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 60m 11s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b JIRA Issue YARN-8169 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919441/YARN-8169.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux d537321e303c 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 1d6e43d maven version: Apache Maven 3.3.9 Default Java 1.8.0_162 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20370/testReport/ Max. process+thread count 301 (vs. ulimit of 10000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/20370/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          aajisaka Akira Ajisaka added a comment -

          LGTM, +1

          aajisaka Akira Ajisaka added a comment - LGTM, +1
          aajisaka Akira Ajisaka added a comment - - edited

          Cancelling my +1.
          Would you add a period to the end of the javadoc of the constructor to fix the below checkstyle warning?
          https://builds.apache.org/job/PreCommit-YARN-Build/20370/artifact/out/patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt

          ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46:  /**: First sentence should end with a period. [JavadocStyle]
          

          I'm +1 if that is addressed.

          aajisaka Akira Ajisaka added a comment - - edited Cancelling my +1. Would you add a period to the end of the javadoc of the constructor to fix the below checkstyle warning? https://builds.apache.org/job/PreCommit-YARN-Build/20370/artifact/out/patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46: /**: First sentence should end with a period. [JavadocStyle] I'm +1 if that is addressed.
          leftnoteasy Wangda Tan added a comment -

          belugabehr

          it's better to keep the:

          if (LOG.isDebugEnabled()) { ... } 

          Check for performance.

          leftnoteasy Wangda Tan added a comment - belugabehr ,  it's better to keep the: if (LOG.isDebugEnabled()) { ... } Check for performance.
          belugabehr David Mollitor added a comment -

          leftnoteasy

          Parameters are best for slf4j:

          1. Avoids double-checking the 'debug enabled' flag
          2. Faster than run-time String concatenation
          3. Less code clutter
          4. Produces smaller product binary (saves memory and execution cache)

          https://www.slf4j.org/faq.html#logging_performance

          belugabehr David Mollitor added a comment - leftnoteasy Parameters are best for slf4j: Avoids double-checking the 'debug enabled' flag Faster than run-time String concatenation Less code clutter Produces smaller product binary (saves memory and execution cache) https://www.slf4j.org/faq.html#logging_performance
          belugabehr David Mollitor added a comment -

          Added period to fix CheckStyle

          belugabehr David Mollitor added a comment - Added period to fix CheckStyle
          leftnoteasy Wangda Tan added a comment -

          belugabehr, thanks for the clarification, very helpful!

          leftnoteasy Wangda Tan added a comment - belugabehr , thanks for the clarification, very helpful!
          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 32s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 22m 40s trunk passed
          +1 compile 0m 32s trunk passed
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 shadedclient 9m 10s branch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 8s trunk passed
          +1 javadoc 0m 33s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 34s the patch passed
          +1 compile 0m 28s the patch passed
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)
          +1 mvnsite 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 9m 25s patch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 14s the patch passed
          +1 javadoc 0m 31s the patch passed
                Other Tests
          +1 unit 2m 59s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          51m 40s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b
          JIRA Issue YARN-8169
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919623/YARN.8169.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 597089ac1e50 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / bf2f493
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_162
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20392/testReport/
          Max. process+thread count 408 (vs. ulimit of 10000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/20392/console
          Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 22m 40s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 34s trunk passed +1 shadedclient 9m 10s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 8s trunk passed +1 javadoc 0m 33s trunk passed       Patch Compile Tests +1 mvninstall 0m 34s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5) +1 mvnsite 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 25s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 14s the patch passed +1 javadoc 0m 31s the patch passed       Other Tests +1 unit 2m 59s hadoop-yarn-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 51m 40s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b JIRA Issue YARN-8169 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919623/YARN.8169.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 597089ac1e50 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / bf2f493 maven version: Apache Maven 3.3.9 Default Java 1.8.0_162 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20392/testReport/ Max. process+thread count 408 (vs. ulimit of 10000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/20392/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          belugabehr David Mollitor added a comment -

          ajisakaa Checkstyle corrected

          belugabehr David Mollitor added a comment - ajisakaa Checkstyle corrected
          aajisaka Akira Ajisaka added a comment -

          +1, thanks belugabehr!

          aajisaka Akira Ajisaka added a comment - +1, thanks belugabehr !
          aajisaka Akira Ajisaka added a comment -

          Committed this to trunk. Thanks belugabehr and leftnoteasy!

          aajisaka Akira Ajisaka added a comment - Committed this to trunk. Thanks belugabehr and leftnoteasy !

          People

            belugabehr David Mollitor
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: