The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
trunk Compile Tests
+1
mvninstall
25m 12s
trunk passed
+1
compile
0m 37s
trunk passed
+1
checkstyle
0m 27s
trunk passed
+1
mvnsite
0m 42s
trunk passed
+1
shadedclient
11m 21s
branch has no errors when building and testing our client artifacts.
+1
findbugs
1m 17s
trunk passed
+1
javadoc
0m 41s
trunk passed
Patch Compile Tests
+1
mvninstall
0m 37s
the patch passed
+1
compile
0m 33s
the patch passed
+1
javac
0m 33s
the patch passed
+1
checkstyle
0m 22s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5)
+1
mvnsite
0m 35s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
shadedclient
11m 29s
patch has no errors when building and testing our client artifacts.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46: /**: First sentence should end with a period. [JavadocStyle]
I'm +1 if that is addressed.
Akira Ajisaka
added a comment - - edited Cancelling my +1.
Would you add a period to the end of the javadoc of the constructor to fix the below checkstyle warning?
https://builds.apache.org/job/PreCommit-YARN-Build/20370/artifact/out/patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/RackResolver.java:46: /**: First sentence should end with a period. [JavadocStyle]
I'm +1 if that is addressed.
David Mollitor
added a comment - leftnoteasy
Parameters are best for slf4j:
Avoids double-checking the 'debug enabled' flag
Faster than run-time String concatenation
Less code clutter
Produces smaller product binary (saves memory and execution cache)
https://www.slf4j.org/faq.html#logging_performance
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
trunk Compile Tests
+1
mvninstall
22m 40s
trunk passed
+1
compile
0m 32s
trunk passed
+1
checkstyle
0m 21s
trunk passed
+1
mvnsite
0m 34s
trunk passed
+1
shadedclient
9m 10s
branch has no errors when building and testing our client artifacts.
+1
findbugs
1m 8s
trunk passed
+1
javadoc
0m 33s
trunk passed
Patch Compile Tests
+1
mvninstall
0m 34s
the patch passed
+1
compile
0m 28s
the patch passed
+1
javac
0m 28s
the patch passed
+1
checkstyle
0m 18s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)
+1
mvnsite
0m 29s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
shadedclient
9m 25s
patch has no errors when building and testing our client artifacts.
YARN-8169This message was automatically generated.