Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8165

Incorrect queue name logging in AbstractContainerAllocator

Details

    • Reviewed

    Description

      Found some incorrect logging messages in RM log

      INFO Reserved container  application=application_1523849397637_0006 resource=<memory:1024, vCores:1> queue=org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.RegularContainerAllocator@38224385 cluster=<memory:2048000, vCores:2000>
      ...
      INFO AbstractContainerAllocator:131 - assignedContainer application attempt=appattempt_1523849397637_0006_000001 container=null queue=org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.RegularContainerAllocator@38224385 clusterResource=<memory:2048000, vCores:2000> type=OFF_SWITCH requestedPartition=
      

      Note, value for queue is incorrect.

      Attachments

        1. YARN-8165.001.patch
          2 kB
          Weiwei Yang

        Issue Links

          Activity

            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 1m 1s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests
            +1 mvninstall 42m 56s trunk passed
            +1 compile 1m 34s trunk passed
            +1 checkstyle 1m 6s trunk passed
            +1 mvnsite 1m 44s trunk passed
            +1 shadedclient 17m 25s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 12s trunk passed
            +1 javadoc 0m 27s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 43s the patch passed
            +1 compile 0m 38s the patch passed
            +1 javac 0m 38s the patch passed
            +1 checkstyle 0m 32s the patch passed
            +1 mvnsite 0m 43s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 11m 12s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 20s the patch passed
            +1 javadoc 0m 26s the patch passed
                  Other Tests
            +1 unit 65m 12s hadoop-yarn-server-resourcemanager in the patch passed.
            +1 asflicense 0m 22s The patch does not generate ASF License warnings.
            146m 49s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b
            JIRA Issue YARN-8165
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919148/YARN-8165.001.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux e9912b7000da 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 896b473
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_162
            findbugs v3.1.0-RC1
            Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20355/testReport/
            Max. process+thread count 830 (vs. ulimit of 10000)
            modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Console output https://builds.apache.org/job/PreCommit-YARN-Build/20355/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 1s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 42m 56s trunk passed +1 compile 1m 34s trunk passed +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 44s trunk passed +1 shadedclient 17m 25s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 12s trunk passed +1 javadoc 0m 27s trunk passed       Patch Compile Tests +1 mvninstall 0m 43s the patch passed +1 compile 0m 38s the patch passed +1 javac 0m 38s the patch passed +1 checkstyle 0m 32s the patch passed +1 mvnsite 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 11m 12s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 20s the patch passed +1 javadoc 0m 26s the patch passed       Other Tests +1 unit 65m 12s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 146m 49s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b JIRA Issue YARN-8165 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12919148/YARN-8165.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux e9912b7000da 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 896b473 maven version: Apache Maven 3.3.9 Default Java 1.8.0_162 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/20355/testReport/ Max. process+thread count 830 (vs. ulimit of 10000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/20355/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            Thanks cheersyang for the patch.

            LGTM +1. 

            elgoiri can you push it to trunk and branch-2?

            The wrong log is also in branch-2.9.

            giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks cheersyang for the patch. LGTM +1.  elgoiri can you push it to trunk and branch-2? The wrong log is also in branch-2.9.

            Thanks cheersyang for the patch and giovanni.fumarola for the review.
            Committed to branch-2 and trunk.

            elgoiri Íñigo Goiri added a comment - Thanks cheersyang for the patch and giovanni.fumarola for the review. Committed to branch-2 and trunk.
            cheersyang Weiwei Yang added a comment - Thanks elgoiri , giovanni.fumarola .
            sunilg Sunil G added a comment -

            Thanks folks for correcting this.

            I cherry-picked to branch-3.1 and branch-3.0 as well. It should be in branch-2 also i think, cheersyang elgoiri, cud u pls confirm

            sunilg Sunil G added a comment - Thanks folks for correcting this. I cherry-picked to branch-3.1 and branch-3.0 as well. It should be in branch-2 also i think, cheersyang elgoiri , cud u pls confirm
            cheersyang Weiwei Yang added a comment -

            Hi sunilg

            Thanks for the cherry-picking. And per elgoiri, this should be already committed to branch-2. The fixed version looks good to me. Thank you.

            cheersyang Weiwei Yang added a comment - Hi sunilg Thanks for the cherry-picking. And per elgoiri , this should be already committed to branch-2. The fixed version looks good to me. Thank you.

            People

              cheersyang Weiwei Yang
              cheersyang Weiwei Yang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: