[YARN-804] mark AbstractService init/start/stop methods as final

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.1.0-beta
• Component/s: api
• Assignee: Vinod Kumar Vavilapalli
• Reporter: Steve Loughran
• Created: 13/Jun/13 17:04
• Updated: 02/Jun/14 08:31
• Resolved: 02/Jun/14 08:31

Description

Now that YARN-117 and MAPREDUCE-5298 are checked in, we can mark the public AbstractService init/start/stop methods as final.

Why? It puts the lifecycle check and error handling around the subclass code, ensuring no lifecycle method gets called in the wrong state or gets called more than once.When a serviceInit(), serviceStart() & serviceStop() method throws an exception, it's caught and auto-triggers stop.

Marking the methods as final forces service implementations to move to the stricter lifecycle. It has one side effect: some of the mocking tests play up -I'll need some assistance here

Issue Links

• contains: YARN-811 Add a set of final _init/_start/_stop methods to CompositeService
• relates to: YARN-117 Enhance YARN service model