[YARN-8017] Validate the application ID has been persisted to the service definition prior to use

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Assignee: Billie Rinaldi
• Reporter: Shane Kumpf
• Due: 30/Apr/18
• Created: 09/Mar/18 21:02
• Updated: 13/Apr/18 02:25
• Resolved: 13/Apr/18 02:25

Description

The service definition is persisted to disk prior to launching the application. Once the application is launched, the service definition is updated to include the application ID. If submit fails, the application ID is never added to the previously persisted service definition.

When this occurs, attempting to stop or destroy the application results in a NPE while trying to get the application ID from the service definition, making it impossible to clean up.

2018-03-02 18:28:05,512 INFO org.apache.hadoop.yarn.service.utils.ServiceApiUtil: Loading service definition from hdfs://y7001.yns.hortonworks.com:8020/user/hadoopuser/.yarn/services/skumpfcents/skumpfcents.json
2018-03-02 18:28:05,525 WARN org.apache.hadoop.yarn.webapp.GenericExceptionHandler: INTERNAL_SERVER_ERROR
java.lang.NullPointerException
	at org.apache.hadoop.yarn.api.records.ApplicationId.fromString(ApplicationId.java:111)
	at org.apache.hadoop.yarn.service.client.ServiceClient.getAppId(ServiceClient.java:1106)
	at org.apache.hadoop.yarn.service.client.ServiceClient.actionStop(ServiceClient.java:363)
	at org.apache.hadoop.yarn.service.webapp.ApiServer$4.run(ApiServer.java:251)
	at org.apache.hadoop.yarn.service.webapp.ApiServer$4.run(ApiServer.java:243)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)

Issue Links

• duplicates: YARN-7984 Delete registry entries from ZK on ServiceClient stop and clean up stop/destroy behavior