[YARN-7985] Service name is validated twice in ServiceClient when a service is created

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Fix Version/s: 3.1.0
• Component/s: yarn-native-services
• Target Version/s: 3.2.0
• Assignee: Chandni Singh
• Reporter: Chandni Singh
• Created: 28/Feb/18 00:10
• Updated: 19/Mar/18 18:33
• Resolved: 01/Mar/18 01:53

Description

In ServiceClient.actionCreate() :

ServiceApiUtil.validateNameFormat(serviceName, getConfig());
ServiceApiUtil.validateAndResolveService(service, fs, getConfig());

However, the ServiceApiUtil.validateAndResolveService(...), also validates the service name

if (StringUtils.isEmpty(service.getName())) {
  throw new IllegalArgumentException(
      RestApiErrorMessages.ERROR_APPLICATION_NAME_INVALID);
}

validateNameFormat(service.getName(), conf);

Also, ServiceClientTest  which is a mock client for the ApiServer, can perform the actual validation which is performed by the ServiceClient