Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7956

[UI2] Avoid duplicating Components link under Services/<ServiceName>/Components

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.1.0
    • 3.2.0, 3.1.1
    • yarn-ui-v2
    • None
    • Reviewed

    Description

      Scenario:

      1) Start Yarn service
      2) Click on a Running yarn service ( example : yesha-sleeper)
      http://xxxx:8088/ui2/#/yarn-app/application_1518804855867_0002/components?service=yesha-sleeper
      3) Now click on yesha-sleeper [application_1518804855867_0002] link

      Both components and yesha-sleeper [application_1518804855867_0002] link point to one page. 
      HOME/Services/<ServiceName> and HOME/Services/<ServiceName>/Components refer to same page.

      We should not need two links to refer to one page

       

      Attachments

        1. Screen Shot 2018-03-20 at 4.19.37 PM.png
          232 kB
          Yesha Vora
        2. YARN-7956.001.patch
          2 kB
          Yesha Vora
        3. YARN-7956.002.patch
          2 kB
          Sunil G

        Activity

          yeshavora Yesha Vora added a comment -

          Removed the link from HOME/Services/<ServiceName>/Components.

          yeshavora Yesha Vora added a comment - Removed the link from HOME/Services/<ServiceName>/Components.
          sunilg Sunil G added a comment -

          Looks straight forward. +1

          Committing shortly. Thank yeshavora

          sunilg Sunil G added a comment - Looks straight forward. +1 Committing shortly. Thank yeshavora
          sunilg Sunil G added a comment -

          Merged to trunk and branch-3.1.
          Compiled and tested in local cluster. Behavior is as expected.

          sunilg Sunil G added a comment - Merged to trunk and branch-3.1. Compiled and tested in local cluster. Behavior is as expected.
          sunilg Sunil G added a comment - - edited

          reopening jira to run jenkins.
          I also reverted from trunk and jenkins was some how didnt run earlier.

          sunilg Sunil G added a comment - - edited reopening jira to run jenkins. I also reverted from trunk and jenkins was some how didnt run earlier.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14036 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14036/)
          YARN-7956. [UI2] Avoid duplicating Components link under (sunilg: rev a11ce19f47bbca4ccb00b32b3ccbda5316a01ae0)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14036 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14036/ ) YARN-7956 . [UI2] Avoid duplicating Components link under (sunilg: rev a11ce19f47bbca4ccb00b32b3ccbda5316a01ae0) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14037/)
          Revert "YARN-7956. [UI2] Avoid duplicating Components link under (sunilg: rev 7fd878813bed4640ac2e9964cbb165099899f150)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14037/ ) Revert " YARN-7956 . [UI2] Avoid duplicating Components link under (sunilg: rev 7fd878813bed4640ac2e9964cbb165099899f150) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js
          sunilg Sunil G added a comment -

          Re attaching same patch to run jenkins

          sunilg Sunil G added a comment - Re attaching same patch to run jenkins
          genericqa genericqa added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 35s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
                trunk Compile Tests
          +1 mvninstall 26m 19s trunk passed
          +1 shadedclient 36m 22s branch has no errors when building and testing our client artifacts.
                Patch Compile Tests
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 12m 11s patch has no errors when building and testing our client artifacts.
                Other Tests
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          50m 1s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b
          JIRA Issue YARN-7956
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12920126/YARN-7956.002.patch
          Optional Tests asflicense shadedclient
          uname Linux 3a8baa5e4058 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / 28e2244
          maven version: Apache Maven 3.3.9
          Max. process+thread count 340 (vs. ulimit of 10000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/20434/console
          Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests +1 mvninstall 26m 19s trunk passed +1 shadedclient 36m 22s branch has no errors when building and testing our client artifacts.       Patch Compile Tests +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 12m 11s patch has no errors when building and testing our client artifacts.       Other Tests +1 asflicense 0m 23s The patch does not generate ASF License warnings. 50m 1s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b JIRA Issue YARN-7956 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12920126/YARN-7956.002.patch Optional Tests asflicense shadedclient uname Linux 3a8baa5e4058 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 28e2244 maven version: Apache Maven 3.3.9 Max. process+thread count 340 (vs. ulimit of 10000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/20434/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14045/)
          YARN-7956. [UI2] Avoid duplicating Components link under (sunilg: rev b6d94fad0811c5b635476d03acea417b277d382b)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14045/ ) YARN-7956 . [UI2] Avoid duplicating Components link under (sunilg: rev b6d94fad0811c5b635476d03acea417b277d382b) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instances.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-component-instance.js

          People

            yeshavora Yesha Vora
            yeshavora Yesha Vora
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: