[YARN-7734] YARN-5418 breaks TestContainerLogsPage.testContainerLogPageAccess

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.0, 3.0.1
• Fix Version/s: 3.2.0, 3.1.1, 3.0.3
• Hadoop Flags: Reviewed
• Assignee: Tao Yang
• Reporter: Miklos Szegedi
• Created: 11/Jan/18 04:14
• Updated: 19/Apr/18 02:59
• Resolved: 28/Mar/18 09:45

Description

It adds a call to LogAggregationFileControllerFactory where the context is not filled in with the configuration in the mock in the unit test.

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.492 s <<< FAILURE! - in org.apache.hadoop.yarn.server.nodemanager.webapp.TestContainerLogsPage
[ERROR] testContainerLogPageAccess(org.apache.hadoop.yarn.server.nodemanager.webapp.TestContainerLogsPage)  Time elapsed: 0.208 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.hadoop.yarn.logaggregation.filecontroller.LogAggregationFileControllerFactory.<init>(LogAggregationFileControllerFactory.java:68)
	at org.apache.hadoop.yarn.server.nodemanager.webapp.ContainerLogsPage$ContainersLogsBlock.<init>(ContainerLogsPage.java:100)
	at org.apache.hadoop.yarn.server.nodemanager.webapp.TestContainerLogsPage.testContainerLogPageAccess(TestContainerLogsPage.java:268)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)

Issue Links

• is caused by: YARN-5418 When partial log aggregation is enabled, display the list of aggregated files on the container log page