[YARN-7698] A misleading variable's name in ApplicationAttemptEventDispatcher

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.1
• Component/s: resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Jinjiang Ling
• Reporter: Jinjiang Ling
• Created: 04/Jan/18 12:02
• Updated: 29/Jan/18 15:49
• Resolved: 29/Jan/18 15:14

Description

I find there are two variables named "appAttemptId" in ApplicationAttemptEventDispatcher.

public static final class ApplicationAttemptEventDispatcher implements
      EventHandler<RMAppAttemptEvent> {
    ....
    public void handle(RMAppAttemptEvent event) {
      ApplicationAttemptId appAttemptID = event.getApplicationAttemptId();
      ApplicationId appAttemptId = appAttemptID.getApplicationId();
      ....
    }

The first one is named as "appAttemptID" which is the true attempt id.
The other one is named as "appAttemptId", but I think it's currect name should be "appId".

I'm not sure there are any reason to name the application id as "appAttemptId". But I think two "appAttemptId" in one function may cause some misleading, so it's better to fix the second one to "appId"