Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7527

Over-allocate node resource in async-scheduling mode of CapacityScheduler

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-alpha4, 2.9.1
    • Fix Version/s: 3.1.0, 3.0.1
    • Component/s: capacityscheduler
    • Labels:
      None

      Description

      Currently in async-scheduling mode of CapacityScheduler, node resource may be over-allocated since node resource check is ignored.
      FiCaSchedulerApp#commonCheckContainerAllocation will check whether this node have enough available resource for this proposal and return check result (ture/false), but this result is ignored in CapacityScheduler#accept as below.

      commonCheckContainerAllocation(allocation, schedulerContainer);
      

      If FiCaSchedulerApp#commonCheckContainerAllocation returns false, CapacityScheduler#accept should also return false as below:

      if (!commonCheckContainerAllocation(allocation, schedulerContainer)) {
        return false;
      }
      
      1. YARN-7527-branch-2.001.patch
        6 kB
        Tao Yang
      2. YARN-7527.001.patch
        6 kB
        Tao Yang

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              branch-2 Compile Tests
        +1 mvninstall 9m 15s branch-2 passed
        +1 compile 0m 36s branch-2 passed
        +1 checkstyle 0m 21s branch-2 passed
        +1 mvnsite 0m 41s branch-2 passed
        +1 findbugs 1m 14s branch-2 passed
        +1 javadoc 0m 25s branch-2 passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 33s the patch passed
        -1 javac 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14)
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 23s the patch passed
        +1 javadoc 0m 24s the patch passed
              Other Tests
        -1 unit 77m 13s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        95m 13s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
          hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0
        JIRA Issue YARN-7527
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898790/YARN-7527-branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
        uname Linux f82939c1cae9 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / db2651c
        maven version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
        Default Java 1.7.0_151
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-YARN-Build/18624/artifact/out/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/18624/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18624/testReport/
        Max. process+thread count 791 (vs. ulimit of 5000)
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/18624/console
        Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 9m 15s branch-2 passed +1 compile 0m 36s branch-2 passed +1 checkstyle 0m 21s branch-2 passed +1 mvnsite 0m 41s branch-2 passed +1 findbugs 1m 14s branch-2 passed +1 javadoc 0m 25s branch-2 passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 0m 33s the patch passed -1 javac 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14) +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 24s the patch passed       Other Tests -1 unit 77m 13s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 95m 13s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0 JIRA Issue YARN-7527 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898790/YARN-7527-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux f82939c1cae9 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision branch-2 / db2651c maven version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) Default Java 1.7.0_151 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-YARN-Build/18624/artifact/out/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/18624/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18624/testReport/ Max. process+thread count 791 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/18624/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Yang Tao Yang added a comment -

        Thanks Wangda Tan for review and commit. Attaching patch for branch-2.

        Show
        Tao Yang Tao Yang added a comment - Thanks Wangda Tan for review and commit. Attaching patch for branch-2.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Tao Yang, pushed to branch-3.0/trunk. There're some minor conflict with branch-2, could you upload patch against branch-2?

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Tao Yang , pushed to branch-3.0/trunk. There're some minor conflict with branch-2, could you upload patch against branch-2?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13260 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13260/)
        YARN-7527. Over-allocate node resource in async-scheduling mode of (wangda: rev 0d781dd03b979d65de94978071b2faa55005b34a)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAsyncScheduling.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13260 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13260/ ) YARN-7527 . Over-allocate node resource in async-scheduling mode of (wangda: rev 0d781dd03b979d65de94978071b2faa55005b34a) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAsyncScheduling.java
        Hide
        leftnoteasy Wangda Tan added a comment -

        Tao Yang, fix looks good to me. And test failures are not related. Will commit the patch by end of today if no objections.

        Show
        leftnoteasy Wangda Tan added a comment - Tao Yang , fix looks good to me. And test failures are not related. Will commit the patch by end of today if no objections.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 12s trunk passed
        +1 compile 0m 36s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 40s trunk passed
        +1 shadedclient 10m 15s branch has no errors when building and testing our client artifacts.
        -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 20s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 37s the patch passed
        +1 compile 0m 33s the patch passed
        +1 javac 0m 33s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedclient 9m 31s patch has no errors when building and testing our client artifacts.
        +1 findbugs 1m 3s the patch passed
        +1 javadoc 0m 19s the patch passed
              Other Tests
        -1 unit 59m 55s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        101m 44s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
          org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
          org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
        JIRA Issue YARN-7527
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898155/YARN-7527.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
        uname Linux c242bb1750b6 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5f0b238
        maven version: Apache Maven 3.3.9
        Default Java 1.8.0_151
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/18550/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/18550/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18550/testReport/
        Max. process+thread count 822 (vs. ulimit of 5000)
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/18550/console
        Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 12s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 40s trunk passed +1 shadedclient 10m 15s branch has no errors when building and testing our client artifacts. -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 20s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 31s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 59m 55s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 101m 44s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue YARN-7527 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898155/YARN-7527.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux c242bb1750b6 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 5f0b238 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/18550/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/18550/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18550/testReport/ Max. process+thread count 822 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/18550/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Tao Yang Tao Yang added a comment -

        Attaching init patch for review.

        Show
        Tao Yang Tao Yang added a comment - Attaching init patch for review.

          People

          • Assignee:
            Tao Yang Tao Yang
            Reporter:
            Tao Yang Tao Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development