Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • YARN-5881
    • 3.1.0
    • test
    • None
    • Reviewed

    Description

      Few UT cases has to be cleaned or rewritten cleanly to consider both absolute/percentage based configuration.

      Related test classes

      1. TestLeafQueue
      2. TestCapacityScheduler
      3. TestCapacitySchedulerWithMultiResourceTypes

      Attachments

        1. YARN-7483.001.patch
          10 kB
          Sunil G
        2. YARN-7483-YARN-5881.001.patch
          10 kB
          Sunil G

        Activity

          sunilg Sunil G added a comment -

          Attaching patch to clean up test case issues.

          cc/ leftnoteasy please help to review.

          sunilg Sunil G added a comment - Attaching patch to clean up test case issues. cc/ leftnoteasy please help to review.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s YARN-7483 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s YARN-7483 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-7483 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898012/YARN-7483.001.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/18524/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          sunilg Sunil G added a comment -

          renamed patch to apply to YARN-5881 branch

          sunilg Sunil G added a comment - renamed patch to apply to YARN-5881 branch
          leftnoteasy Wangda Tan added a comment -

          Patch looks good, pending Jenkins.

          leftnoteasy Wangda Tan added a comment - Patch looks good, pending Jenkins.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                YARN-5881 Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 14m 57s YARN-5881 passed
          +1 compile 7m 13s YARN-5881 passed
          +1 checkstyle 1m 2s YARN-5881 passed
          +1 mvnsite 1m 31s YARN-5881 passed
          +1 shadedclient 12m 4s branch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 14s YARN-5881 passed
          +1 javadoc 1m 3s YARN-5881 passed
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 10s the patch passed
          +1 compile 5m 57s the patch passed
          +1 javac 5m 57s the patch passed
          -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 373 unchanged - 0 fixed = 389 total (was 373)
          +1 mvnsite 1m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 9m 51s patch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 25s the patch passed
          +1 javadoc 1m 1s the patch passed
                Other Tests
          +1 unit 2m 36s hadoop-yarn-common in the patch passed.
          -1 unit 60m 45s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          125m 58s



          Reason Tests
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
            org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
          JIRA Issue YARN-7483
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898015/YARN-7483-YARN-5881.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 61ca52d4a37f 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision YARN-5881 / 147a526
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_151
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/18525/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/18525/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18525/testReport/
          Max. process+thread count 822 (vs. ulimit of 5000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/18525/console
          Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       YARN-5881 Compile Tests 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 14m 57s YARN-5881 passed +1 compile 7m 13s YARN-5881 passed +1 checkstyle 1m 2s YARN-5881 passed +1 mvnsite 1m 31s YARN-5881 passed +1 shadedclient 12m 4s branch has no errors when building and testing our client artifacts. +1 findbugs 2m 14s YARN-5881 passed +1 javadoc 1m 3s YARN-5881 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 5m 57s the patch passed +1 javac 5m 57s the patch passed -0 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 16 new + 373 unchanged - 0 fixed = 389 total (was 373) +1 mvnsite 1m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 51s patch has no errors when building and testing our client artifacts. +1 findbugs 2m 25s the patch passed +1 javadoc 1m 1s the patch passed       Other Tests +1 unit 2m 36s hadoop-yarn-common in the patch passed. -1 unit 60m 45s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 125m 58s Reason Tests Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue YARN-7483 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12898015/YARN-7483-YARN-5881.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 61ca52d4a37f 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision YARN-5881 / 147a526 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/18525/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/18525/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18525/testReport/ Max. process+thread count 822 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/18525/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          leftnoteasy Wangda Tan added a comment -

          Committed to YARN-5881, thanks sunilg.

          leftnoteasy Wangda Tan added a comment - Committed to YARN-5881 , thanks sunilg .
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13345/)
          YARN-7483. CapacityScheduler test cases cleanup post YARN-5881. (Sunil G (wangda: rev 7462c38277fa415703fc9074c1288d3bec73609c)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13345/ ) YARN-7483 . CapacityScheduler test cases cleanup post YARN-5881 . (Sunil G (wangda: rev 7462c38277fa415703fc9074c1288d3bec73609c) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java

          People

            sunilg Sunil G
            sunilg Sunil G
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: