Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7462

Render outstanding resource requests on application page of new YARN UI

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • yarn-ui-v2
    • None
    • Reviewed

    Attachments

      1. YARN-7462.001.patch
        4 kB
        Vasudevan Skm
      2. Screen Shot 2017-11-08 at 3.24.30 PM.png
        558 kB
        Vasudevan Skm
      3. YARN-7462.002.patch
        4 kB
        Vasudevan Skm
      4. Screen Shot 2017-11-08 at 3.38.48 PM.png
        176 kB
        Vasudevan Skm
      5. YARN-7462.003.patch
        6 kB
        Vasudevan Skm
      6. YARN-7462.004.patch
        8 kB
        Vasudevan Skm

      Activity

        skmvasu Vasudevan Skm added a comment - sunil.govind@gmail.com wangda
        skmvasu Vasudevan Skm added a comment -

        Fixes the typo in the previous patch sunil.govind@gmail.com

        skmvasu Vasudevan Skm added a comment - Fixes the typo in the previous patch sunil.govind@gmail.com
        sunilg Sunil G added a comment -

        skmvasu Thanks for the patch.

        I have one issue in this patch. Post YARN-3926, we support more resource types other than memory and vcores.
        But REST endpoint org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ResourceInfo is not having multiple resource support in a clean way. So post this patch, we need to raise a common ticket in UI to show resources other than memory and cpu also.

        Some minor comments:

        1. .history/ is added to git ignore list. Why this is needed?
        2. Rename Priority to Scheduler Key
        3. ResourceName to Resource Name. A space to be added for better readability
        4. NumContainers. Could we say like # Containers as it indicates a count.
        5. Outstanding resource requests to Outstanding Resource Requests
        6. If model.app.resourceRequests is empty, could we hide the whole table?
        sunilg Sunil G added a comment - skmvasu Thanks for the patch. I have one issue in this patch. Post YARN-3926 , we support more resource types other than memory and vcores. But REST endpoint org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ResourceInfo is not having multiple resource support in a clean way. So post this patch, we need to raise a common ticket in UI to show resources other than memory and cpu also. Some minor comments: .history/ is added to git ignore list. Why this is needed? Rename Priority to Scheduler Key ResourceName to Resource Name . A space to be added for better readability NumContainers . Could we say like # Containers as it indicates a count. Outstanding resource requests to Outstanding Resource Requests If model.app.resourceRequests is empty, could we hide the whole table?
        skmvasu Vasudevan Skm added a comment -

        sunil.govind@gmail.comThank you for the comments.

        Sure, let's handle the API changes in the next patch

        About the other comments,

        1. `.history` is created by `vscode`. This will be helpful for people using vscode as their primary editor
        2-5. Sure. Will update the patch
        6. Hiding the table is bad UX. This will confuse the users. We render no data available in these cases, so the users don't get confused.

        skmvasu Vasudevan Skm added a comment - sunil.govind@gmail.com Thank you for the comments. Sure, let's handle the API changes in the next patch About the other comments, 1. `.history` is created by `vscode`. This will be helpful for people using vscode as their primary editor 2-5. Sure. Will update the patch 6. Hiding the table is bad UX. This will confuse the users. We render no data available in these cases, so the users don't get confused.
        skmvasu Vasudevan Skm added a comment - sunil.govind@gmail.com
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
              trunk Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 17m 34s trunk passed
        +1 shadedclient 27m 44s branch has no errors when building and testing our client artifacts.
              Patch Compile Tests
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedclient 11m 20s patch has no errors when building and testing our client artifacts.
              Other Tests
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        40m 22s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
        JIRA Issue YARN-7462
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897454/YARN-7462.003.patch
        Optional Tests asflicense shadedclient
        uname Linux 447200171ee5 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4f40cd3
        maven version: Apache Maven 3.3.9
        Max. process+thread count 297 (vs. ulimit of 5000)
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/18477/console
        Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 17m 34s trunk passed +1 shadedclient 27m 44s branch has no errors when building and testing our client artifacts.       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 11m 20s patch has no errors when building and testing our client artifacts.       Other Tests +1 asflicense 0m 20s The patch does not generate ASF License warnings. 40m 22s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue YARN-7462 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897454/YARN-7462.003.patch Optional Tests asflicense shadedclient uname Linux 447200171ee5 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 4f40cd3 maven version: Apache Maven 3.3.9 Max. process+thread count 297 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/18477/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        sunilg Sunil G added a comment -

        v3 patch looks good to me. Committing later today if there are no objections.

        sunilg Sunil G added a comment - v3 patch looks good to me. Committing later today if there are no objections.
        skmvasu Vasudevan Skm added a comment -

        LOoks like the api fields have changes in v3. Updating the patch to work with v3 API.

        skmvasu Vasudevan Skm added a comment - LOoks like the api fields have changes in v3. Updating the patch to work with v3 API.
        sunilg Sunil G added a comment -

        pending jenkins

        sunilg Sunil G added a comment - pending jenkins
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
              trunk Compile Tests
        0 mvndep 5m 45s Maven dependency ordering for branch
        +1 mvninstall 15m 17s trunk passed
        +1 shadedclient 30m 13s branch has no errors when building and testing our client artifacts.
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 shadedclient 10m 44s patch has no errors when building and testing our client artifacts.
              Other Tests
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        52m 15s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
        JIRA Issue YARN-7462
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897521/YARN-7462.004.patch
        Optional Tests asflicense shadedclient
        uname Linux 57f44563d06f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/patchprocess/precommit/personality/provided.sh
        git revision trunk / 18621af
        maven version: Apache Maven 3.3.9
        Max. process+thread count 442 (vs. ulimit of 5000)
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/18485/console
        Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 10m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests 0 mvndep 5m 45s Maven dependency ordering for branch +1 mvninstall 15m 17s trunk passed +1 shadedclient 30m 13s branch has no errors when building and testing our client artifacts.       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 44s patch has no errors when building and testing our client artifacts.       Other Tests +1 asflicense 0m 19s The patch does not generate ASF License warnings. 52m 15s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue YARN-7462 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897521/YARN-7462.004.patch Optional Tests asflicense shadedclient uname Linux 57f44563d06f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 18621af maven version: Apache Maven 3.3.9 Max. process+thread count 442 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/18485/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        sunilg Sunil G added a comment -

        Committed to trunk. Thanks skmvasu

        sunilg Sunil G added a comment - Committed to trunk. Thanks skmvasu
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13237 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13237/)
        YARN-7462. Render outstanding resource requests on application page of (sunilg: rev c4c57b80e1e43391417e958f455e25fd7ff67d07)

        • (edit) .gitignore
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/models/yarn-app.js
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/serializers/yarn-app.js
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-app/info.hbs
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13237 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13237/ ) YARN-7462 . Render outstanding resource requests on application page of (sunilg: rev c4c57b80e1e43391417e958f455e25fd7ff67d07) (edit) .gitignore (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/models/yarn-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/serializers/yarn-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-app/info.hbs

        People

          skmvasu Vasudevan Skm
          skmvasu Vasudevan Skm
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: