Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
Filters are missing on the new webui
Attachments
Attachments
- YARN-7445.005.patch
- 35 kB
- Vasudevan Skm
- YARN-7445.004.patch
- 30 kB
- Vasudevan Skm
- YARN-7445.003.patch
- 33 kB
- Vasudevan Skm
- YARN-7445.002.patch
- 29 kB
- Vasudevan Skm
- YARN-7445.001.patch
- 19 kB
- Vasudevan Skm
- Screen Shot 2017-11-06 at 5.59.06 PM.png
- 1.15 MB
- Vasudevan Skm
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
trunk Compile Tests | |||
+1 | mvninstall | 17m 37s | trunk passed |
+1 | shadedclient | 28m 28s | branch has no errors when building and testing our client artifacts. |
Patch Compile Tests | |||
-1 | whitespace | 0m 0s | The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
+1 | shadedclient | 11m 55s | patch has no errors when building and testing our client artifacts. |
Other Tests | |||
+1 | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
41m 24s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12896367/YARN-7445.002.patch |
Optional Tests | asflicense shadedclient |
uname | Linux 1b03a6f84aae 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 13fa2d4 |
maven | version: Apache Maven 3.3.9 |
whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/18372/artifact/out/whitespace-eol.txt |
Max. process+thread count | 329 (vs. ulimit of 5000) |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18372/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 18s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
trunk Compile Tests | |||
+1 | mvninstall | 15m 52s | trunk passed |
+1 | shadedclient | 25m 5s | branch has no errors when building and testing our client artifacts. |
Patch Compile Tests | |||
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 10m 59s | patch has no errors when building and testing our client artifacts. |
Other Tests | |||
+1 | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
37m 7s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12896390/YARN-7445.003.patch |
Optional Tests | asflicense shadedclient |
uname | Linux a0c226e057fb 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 13fa2d4 |
maven | version: Apache Maven 3.3.9 |
Max. process+thread count | 442 (vs. ulimit of 5000) |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18375/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Patch looks fine to me.
vasduevanskm, Progress column has a rendering issue earlier where it looses one pixel in each row. If not done, please include the same in this patch.
Few minor nits.
- pls add alasql.js in LICENSE.txt
- headerTitle: 'Status' should be changed to headerTitle: 'State'
- For state columns, midWidth could be 70 or 75.
Thanks skmvasu for addressing comments
Kicking jenkins manually.
Will commit later today pending jenkins and if there are no objections
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
trunk Compile Tests | |||
+1 | mvninstall | 16m 25s | trunk passed |
+1 | shadedclient | 26m 11s | branch has no errors when building and testing our client artifacts. |
Patch Compile Tests | |||
-1 | whitespace | 0m 0s | The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
+1 | shadedclient | 11m 3s | patch has no errors when building and testing our client artifacts. |
Other Tests | |||
+1 | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
38m 6s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12897007/YARN-7445.004.patch |
Optional Tests | asflicense shadedclient |
uname | Linux e59b4e7a1d56 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 2c2b7a3 |
maven | version: Apache Maven 3.3.9 |
whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/18440/artifact/out/whitespace-eol.txt |
Max. process+thread count | 336 (vs. ulimit of 5000) |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18440/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 18s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
trunk Compile Tests | |||
0 | mvndep | 1m 33s | Maven dependency ordering for branch |
+1 | mvninstall | 15m 0s | trunk passed |
+1 | shadedclient | 25m 57s | branch has no errors when building and testing our client artifacts. |
Patch Compile Tests | |||
0 | mvndep | 0m 17s | Maven dependency ordering for patch |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedclient | 10m 31s | patch has no errors when building and testing our client artifacts. |
Other Tests | |||
+1 | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
37m 53s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12897282/YARN-7445.005.patch |
Optional Tests | asflicense shadedclient |
uname | Linux 9619f4eb6a9f 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 3e26077 |
maven | version: Apache Maven 3.3.9 |
Max. process+thread count | 405 (vs. ulimit of 5000) |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: . |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18461/console |
Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
I am committing this with pixel issue in Progress column as open. As confirmed by skmvasu, this need some skin changes and will addressed in a common jira. Kindly confirm
sunil.govind@gmail.com Yes, it's closed in the reskin story I'm playing now. I'll push the other patch soon.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13226 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13226/)
YARN-7445. Render Applications and Services page with filters in new (sunilg: rev fb62bd625f53f0407f711317b208a6e4de8e43bc)
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/jsconfig.json
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-apps.hbs
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/styles/app.css
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-services.js
- (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/components/em-table-simple-status-cell.hbs
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/config/environment.js
- (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/tests/integration/components/em-table-simple-status-cell-test.js
- (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/em-table-simple-status-cell.js
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/ember-cli-build.js
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/bower.json
- (edit) .gitignore
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/yarn.lock
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/yarn-services.hbs
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/yarn-apps/apps.js
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/controllers/app-table-columns.js
sunil.govind@gmail.comwangda