[YARN-7383] Node resource is not parsed correctly for resource names containing dot

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0, 2.10.0, 3.0.1
• Component/s: nodemanager, resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Gergely Novák
• Reporter: Jonathan Hung
• Created: 24/Oct/17 00:07
• Updated: 30/Aug/19 02:48
• Resolved: 13/Dec/17 16:45

Description

Currently when getting resource capabilities in node-resources.xml, the following parsing code is used:

    String[] parts = prop.split("\\.");
    LOG.info("Found resource entry " + prop);
    if (parts.length == 4) {
      String resourceType = parts[3];
      if (!nodeResources.containsKey(resourceType)) {
        nodeResources
            .put(resourceType, ResourceInformation.newInstance(resourceType));
      }
      String units = getUnits(value);
      Long resourceValue =
          Long.valueOf(value.substring(0, value.length() - units.length()));
      nodeResources.get(resourceType).setValue(resourceValue);
      nodeResources.get(resourceType).setUnits(units);
      if (LOG.isDebugEnabled()) {
        LOG.debug("Setting value for resource type " + resourceType + " to "
            + resourceValue + " with units " + units);
      }
    }

If resource names contain dots though (e.g. for resource names in a namespace) this will not parse correctly.