Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7309

TestClientRMService#testUpdateApplicationPriorityRequest and TestClientRMService#testUpdatePriorityAndKillAppWithZeroClusterResource test functionality not supported by FairScheduler

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0
    • test
    • None
    • Reviewed

    Description

      TestClientRMService#testUpdateApplicationPriorityRequest and TestClientRMService#testUpdatePriorityAndKillAppWithZeroClusterResource test functionality (i.e. Application Priorities) not supported by FairScheduler. We should skip these two tests when using FairScheduler or they'll fail.

      Attachments

        1. YARN-7309.001.patch
          3 kB
          Robert Kanter

        Issue Links

          Activity

            rkanter Robert Kanter added a comment -

            Simple patch to skip the tests with a clear message when using FairScheduler.

            rkanter Robert Kanter added a comment - Simple patch to skip the tests with a clear message when using FairScheduler.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 38s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 32m 31s trunk passed
            +1 compile 1m 40s trunk passed
            +1 checkstyle 1m 2s trunk passed
            +1 mvnsite 1m 37s trunk passed
            +1 shadedclient 18m 16s branch has no errors when building and testing our client artifacts.
            +1 findbugs 2m 44s trunk passed
            +1 javadoc 0m 56s trunk passed
                  Patch Compile Tests
            +1 mvninstall 1m 30s the patch passed
            +1 compile 1m 32s the patch passed
            +1 javac 1m 32s the patch passed
            +1 checkstyle 0m 55s the patch passed
            +1 mvnsite 1m 40s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 18m 29s patch has no errors when building and testing our client artifacts.
            +1 findbugs 3m 13s the patch passed
            +1 javadoc 0m 57s the patch passed
                  Other Tests
            -1 unit 62m 26s hadoop-yarn-server-resourcemanager in the patch failed.
            +1 asflicense 1m 6s The patch does not generate ASF License warnings.
            151m 17s



            Reason Tests
            Failed junit tests hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
              hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
              hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
              hadoop.yarn.server.resourcemanager.TestApplicationMasterService
              hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling
              hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt
              hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
              hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestApplicationCleanup
              org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



            Subsystem Report/Notes
            Docker Image:yetus/hadoop:71bbb86
            JIRA Issue YARN-7309
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891172/YARN-7309.001.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux a4738d48c3de 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
            git revision trunk / f9ff17f
            Default Java 1.8.0_144
            findbugs v3.1.0-RC1
            unit https://builds.apache.org/job/PreCommit-YARN-Build/17834/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
            Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17834/testReport/
            modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Console output https://builds.apache.org/job/PreCommit-YARN-Build/17834/console
            Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 38s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 32m 31s trunk passed +1 compile 1m 40s trunk passed +1 checkstyle 1m 2s trunk passed +1 mvnsite 1m 37s trunk passed +1 shadedclient 18m 16s branch has no errors when building and testing our client artifacts. +1 findbugs 2m 44s trunk passed +1 javadoc 0m 56s trunk passed       Patch Compile Tests +1 mvninstall 1m 30s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed +1 checkstyle 0m 55s the patch passed +1 mvnsite 1m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 18m 29s patch has no errors when building and testing our client artifacts. +1 findbugs 3m 13s the patch passed +1 javadoc 0m 57s the patch passed       Other Tests -1 unit 62m 26s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 1m 6s The patch does not generate ASF License warnings. 151m 17s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestApplicationCleanup   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-7309 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891172/YARN-7309.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux a4738d48c3de 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f9ff17f Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17834/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17834/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17834/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            sunilg Sunil G added a comment -

            Changes look good to me. However there are many test failures, I think these are not related. Could you please help to confirm.
            Otherwise +1

            sunilg Sunil G added a comment - Changes look good to me. However there are many test failures, I think these are not related. Could you please help to confirm. Otherwise +1
            rkanter Robert Kanter added a comment -

            Thanks sunilg for the review. Those failures are definitely not related - the patch only adds an Assume statement to two specific tests and doesn't actually change anything that could affect anything else. I also took a look at the previous run on Jenkins, and the same tests were failing then (without the patch).

            rkanter Robert Kanter added a comment - Thanks sunilg for the review. Those failures are definitely not related - the patch only adds an Assume statement to two specific tests and doesn't actually change anything that could affect anything else. I also took a look at the previous run on Jenkins, and the same tests were failing then (without the patch).
            rkanter Robert Kanter added a comment -

            Committed to trunk and branch-2!

            rkanter Robert Kanter added a comment - Committed to trunk and branch-2!
            sunilg Sunil G added a comment -

            Thanks rkanter. Committing later today if no other objections.

            sunilg Sunil G added a comment - Thanks rkanter . Committing later today if no other objections.
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13061 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13061/)
            YARN-7309. TestClientRMService#testUpdateApplicationPriorityRequest and (rkanter: rev ec8bf9e48ac4dc675516a57c06a29890b5138548)

            • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13061 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13061/ ) YARN-7309 . TestClientRMService#testUpdateApplicationPriorityRequest and (rkanter: rev ec8bf9e48ac4dc675516a57c06a29890b5138548) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java

            People

              rkanter Robert Kanter
              rkanter Robert Kanter
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: