[YARN-7189] Container-executor doesn't remove Docker containers that error out early

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.0, 2.8.3, 3.0.1
• Fix Version/s: 2.10.0, 2.9.2, 3.0.3
• Component/s: yarn
• Labels: Docker
• Hadoop Flags: Reviewed
• Assignee: Eric Badger
• Reporter: Eric Badger
• Created: 13/Sep/17 15:32
• Updated: 02/May/18 22:34
• Resolved: 17/Apr/18 15:25

Description

Once the docker run command is executed, the docker container is created unless the return code is 125 meaning that the run command itself failed (https://docs.docker.com/engine/reference/run/#exit-status). Any error that happens after the docker run needs to remove the container during cleanup.

container-executor.c:launch_docker_container_as_user

  snprintf(docker_command_with_binary, command_size, "%s %s", docker_binary, docker_command);

  fprintf(LOGFILE, "Launching docker container...\n");
  FILE* start_docker = popen(docker_command_with_binary, "r");

This is fixed by YARN-5366, which changes how we remove containers. However, that was committed into 3.1.0. 2.8, 2.9, and 3.0 are all affected