Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7099

ResourceHandlerModule.parseConfiguredCGroupPath only works for privileged yarn users.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: nodemanager
    • Labels:
      None

      Description

      canWrite is failing below:

              if (candidate.isDirectory() && candidate.canWrite()) {
                pathSubsystemMappings.put(candidate.getAbsolutePath(), cgroupList);
              } else {
                LOG.warn("The following cgroup is not a directory or it is not"
                    + " writable" + candidate.getAbsolutePath());
              }
      

        Activity

        Hide
        yufeigu Yufei Gu added a comment -

        Looks good to me. Pending for Hadoop QA.

        Show
        yufeigu Yufei Gu added a comment - Looks good to me. Pending for Hadoop QA.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 45s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 33s trunk passed
        -1 findbugs 0m 50s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 17s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 27s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 28s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 56s the patch passed
        +1 javadoc 0m 17s the patch passed
              Other Tests
        +1 unit 14m 16s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        37m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-7099
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883644/YARN-7099.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4117a9203c68 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 36bada3
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17143/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17143/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/17143/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 45s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 33s trunk passed -1 findbugs 0m 50s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 17s trunk passed       Patch Compile Tests +1 mvninstall 0m 27s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 56s the patch passed +1 javadoc 0m 17s the patch passed       Other Tests +1 unit 14m 16s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 37m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-7099 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883644/YARN-7099.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4117a9203c68 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 36bada3 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17143/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17143/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17143/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        miklos.szegedi@cloudera.com Miklos Szegedi added a comment -

        I removed half a line, so it would be complicated to add a unit test. The findbugs is unrelated.

        Show
        miklos.szegedi@cloudera.com Miklos Szegedi added a comment - I removed half a line, so it would be complicated to add a unit test. The findbugs is unrelated.
        Hide
        yufeigu Yufei Gu added a comment -

        Thanks for the patch, Miklos Szegedi. Committed to trunk and branch-2.

        Show
        yufeigu Yufei Gu added a comment - Thanks for the patch, Miklos Szegedi . Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #12254 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12254/)
        YARN-7099. ResourceHandlerModule.parseConfiguredCGroupPath only works (yufei: rev d5bc9582793de6ab2d2e489cde293bf076229a1c)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/ResourceHandlerModule.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #12254 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12254/ ) YARN-7099 . ResourceHandlerModule.parseConfiguredCGroupPath only works (yufei: rev d5bc9582793de6ab2d2e489cde293bf076229a1c) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/ResourceHandlerModule.java

          People

          • Assignee:
            miklos.szegedi@cloudera.com Miklos Szegedi
            Reporter:
            miklos.szegedi@cloudera.com Miklos Szegedi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development