Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7022

Improve click interaction in queue topology in new YARN UI

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1, 3.1.0
    • Component/s: yarn-ui-v2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, the behavior of interacting with the tree view in the queues tab of the UI is difficult in that you must mouse over to select a queue node and then click to drill down. It would be more intuitive to single click to select a different queue and double-click to drill down instead.

      1. YARN-7022.001.patch
        1 kB
        Abdullah Yousufi

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
              trunk Compile Tests
              Patch Compile Tests
        +1 whitespace 0m 0s The patch has no whitespace issues.
              Other Tests
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        1m 2s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-7022
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882100/YARN-7022.001.patch
        Optional Tests asflicense
        uname Linux e4557d758d2b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 588c190
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16928/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests       Patch Compile Tests +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 asflicense 0m 18s The patch does not generate ASF License warnings. 1m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-7022 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882100/YARN-7022.001.patch Optional Tests asflicense uname Linux e4557d758d2b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 588c190 modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/16928/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        +1 on the intent. I find that highly unintuitive.

        Show
        templedf Daniel Templeton added a comment - +1 on the intent. I find that highly unintuitive.
        Hide
        sunilg Sunil G added a comment -

        Does this mean that a simple mouse hover along the queue icons wont change updated value in below table, rather you have to do a single click to get this?

        Show
        sunilg Sunil G added a comment - Does this mean that a simple mouse hover along the queue icons wont change updated value in below table, rather you have to do a single click to get this?
        Hide
        templedf Daniel Templeton added a comment -

        That's my read of it. I find the new UI counter-intuitive in that no other UIs I use trigger an action based on a hover. With the new UI I always click on the queue to select it and then have to use the back button to get back because clicking unexpectedly takes me to the queue-specific page. In a UI, the general contract is that hover gives pop-up info, click selects, and double-click enters.

        Show
        templedf Daniel Templeton added a comment - That's my read of it. I find the new UI counter-intuitive in that no other UIs I use trigger an action based on a hover. With the new UI I always click on the queue to select it and then have to use the back button to get back because clicking unexpectedly takes me to the queue-specific page. In a UI, the general contract is that hover gives pop-up info, click selects, and double-click enters.
        Hide
        sunilg Sunil G added a comment -

        I think i am fine with this. But cursor has to change as a HAND icon so that user will get a perspective that this is clickable ,also with same queue icon expand feel. Abdullah Yousufi, I guess this can be done easily as its already available. correct?

        Show
        sunilg Sunil G added a comment - I think i am fine with this. But cursor has to change as a HAND icon so that user will get a perspective that this is clickable ,also with same queue icon expand feel. Abdullah Yousufi , I guess this can be done easily as its already available. correct?
        Hide
        ayousufi Abdullah Yousufi added a comment -

        Thanks for the feedback everyone.

        Sunil G Yes, that's correct. I'll upload a patch with that change shortly.

        Show
        ayousufi Abdullah Yousufi added a comment - Thanks for the feedback everyone. Sunil G Yes, that's correct. I'll upload a patch with that change shortly.
        Hide
        ayousufi Abdullah Yousufi added a comment - - edited

        Hey Sunil G, I just checked and the cursor does change to a hand when you hover over a node. Should it do something else in addition?

        Show
        ayousufi Abdullah Yousufi added a comment - - edited Hey Sunil G , I just checked and the cursor does change to a hand when you hover over a node. Should it do something else in addition?
        Hide
        sunilg Sunil G added a comment -

        Yea. This behavior seems fine enough for now i think.

        Show
        sunilg Sunil G added a comment - Yea. This behavior seems fine enough for now i think.
        Hide
        sunilg Sunil G added a comment -

        I ll commit this patch later today if there are no objection.

        Show
        sunilg Sunil G added a comment - I ll commit this patch later today if there are no objection.
        Hide
        sunilg Sunil G added a comment -

        Abdullah Yousufi, sorry for a last minute hiccup. When i click (single), below contents are changing. But the surrounding effect for queue node happening only when i click one more. (not double click, 2 separate single clicks).
        I think this is something different issue. May be we can track is different in new jira and get this committed. Thoughts ?

        Show
        sunilg Sunil G added a comment - Abdullah Yousufi , sorry for a last minute hiccup. When i click (single), below contents are changing. But the surrounding effect for queue node happening only when i click one more. (not double click, 2 separate single clicks). I think this is something different issue. May be we can track is different in new jira and get this committed. Thoughts ?
        Hide
        ayousufi Abdullah Yousufi added a comment -

        Yeah that sounds like a different issue to me. I think a new jira for that is a good idea. Thanks Sunil G.

        Show
        ayousufi Abdullah Yousufi added a comment - Yeah that sounds like a different issue to me. I think a new jira for that is a good idea. Thanks Sunil G .
        Hide
        sunilg Sunil G added a comment -

        Thanks. Please help to raise a new issue.
        I ll commit this shortly.

        Show
        sunilg Sunil G added a comment - Thanks. Please help to raise a new issue. I ll commit this shortly.
        Hide
        sunilg Sunil G added a comment -

        Committed to trunk. Thanks Abdullah Yousufi

        Show
        sunilg Sunil G added a comment - Committed to trunk. Thanks Abdullah Yousufi
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12811 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12811/)
        YARN-7022. Improve click interaction in queue topology in new YARN UI. (sunilg: rev ed162b7aa01a60488d0c95294d4503aac725bd9e)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/tree-selector.js
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12811 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12811/ ) YARN-7022 . Improve click interaction in queue topology in new YARN UI. (sunilg: rev ed162b7aa01a60488d0c95294d4503aac725bd9e) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/tree-selector.js
        Hide
        sunilg Sunil G added a comment -

        back-ported to branch-3 as well.

        Show
        sunilg Sunil G added a comment - back-ported to branch-3 as well.

          People

          • Assignee:
            ayousufi Abdullah Yousufi
            Reporter:
            ayousufi Abdullah Yousufi
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development