Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-beta1
    • federation
    • None
    • Reviewed

    Description

      During an execution we found that Hikari can throw a PoolInitializationException. It has to be an retriable exception in FederationStateStoreFacade.

      Attachments

        1. YARN-6970.v1.patch
          3 kB
          Giovanni Matteo Fumarola

        Activity

          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 5s trunk passed
          +1 compile 0m 24s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 25s trunk passed
          +1 findbugs 0m 45s trunk passed
          +1 javadoc 0m 14s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 18s the patch passed
          +1 javac 0m 18s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 47s the patch passed
          +1 javadoc 0m 14s the patch passed
                Other Tests
          +1 unit 1m 13s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 13s The patch does not generate ASF License warnings.
          20m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6970
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880898/YARN-6970.v1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e66907f66745 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1794de3
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16789/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16789/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 5s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 25s trunk passed +1 findbugs 0m 45s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 47s the patch passed +1 javadoc 0m 14s the patch passed       Other Tests +1 unit 1m 13s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 13s The patch does not generate ASF License warnings. 20m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6970 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880898/YARN-6970.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e66907f66745 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1794de3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16789/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/16789/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          Thanks giovanni.fumarola for contributing the patch. IIRC, we discussed adding more exceptions for retry like SQLException?

          subru Subramaniam Krishnan added a comment - Thanks giovanni.fumarola for contributing the patch. IIRC, we discussed adding more exceptions for retry like SQLException ?

          SQLException in SQLFederationStateStore are treated as RetriableException. So far, we added all the exceptions that require a retry logic.

          giovanni.fumarola Giovanni Matteo Fumarola added a comment - SQLException in SQLFederationStateStore are treated as RetriableException . So far, we added all the exceptions that require a retry logic.

          Thanks giovanni.fumarola for the clarification, I have committed this to trunk.

          subru Subramaniam Krishnan added a comment - Thanks giovanni.fumarola for the clarification, I have committed this to trunk.

          People

            giovanni.fumarola Giovanni Matteo Fumarola
            giovanni.fumarola Giovanni Matteo Fumarola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: