Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6932

Fix TestFederationRMFailoverProxyProvider test case failure

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Noticed that TestFederationRMFailoverProxyProvider after the YARN-2915 merge
      (cc Subru Krishnan)

      1. YARN-6932-v1.patch
        2 kB
        Subru Krishnan

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12113 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12113/)
        YARN-6932. Fix TestFederationRMFailoverProxyProvider test case failure. (subru: rev 0542e6f86e6734f8ceea00960bebe719827136db)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/failover/FederationRMFailoverProxyProvider.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12113 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12113/ ) YARN-6932 . Fix TestFederationRMFailoverProxyProvider test case failure. (subru: rev 0542e6f86e6734f8ceea00960bebe719827136db) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/failover/FederationRMFailoverProxyProvider.java
        Hide
        subru Subru Krishnan added a comment -

        Thanks Botong Huang for the in depth investigation and Arun Suresh for reporting/reviewing it, I just committed this to trunk.

        Show
        subru Subru Krishnan added a comment - Thanks Botong Huang for the in depth investigation and Arun Suresh for reporting/reviewing it, I just committed this to trunk.
        Hide
        botong Botong Huang added a comment -

        Thanks Subru Krishnan for the patch. I've investigated a bit, it is already failing at the initial commit. Because of the rebasing of YARN-2915 we cannot get to the exact point any more and understand why the test is passing when checked in. Anyways, the patch looks good to me.

        Show
        botong Botong Huang added a comment - Thanks Subru Krishnan for the patch. I've investigated a bit, it is already failing at the initial commit. Because of the rebasing of YARN-2915 we cannot get to the exact point any more and understand why the test is passing when checked in. Anyways, the patch looks good to me.
        Hide
        asuresh Arun Suresh added a comment -

        +1. Thanks subru

        Show
        asuresh Arun Suresh added a comment - +1. Thanks subru
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 24s trunk passed
        +1 compile 0m 21s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 findbugs 0m 42s trunk passed
        +1 javadoc 0m 15s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 50s the patch passed
        +1 javadoc 0m 14s the patch passed
              Other Tests
        +1 unit 1m 8s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 12s The patch does not generate ASF License warnings.
        20m 17s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6932
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880128/YARN-6932-v1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 58d4731b4625 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 79df1e7
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16674/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16674/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 24s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 23s trunk passed +1 findbugs 0m 42s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 21s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 50s the patch passed +1 javadoc 0m 14s the patch passed       Other Tests +1 unit 1m 8s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 12s The patch does not generate ASF License warnings. 20m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6932 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880128/YARN-6932-v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 58d4731b4625 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79df1e7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16674/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/16674/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Arun Suresh for raising this. I am attaching a simple fix as looks like the null check in FederationRMFailoverProxyProvider::closeInternal was at wrong level.

        Show
        subru Subru Krishnan added a comment - Thanks Arun Suresh for raising this. I am attaching a simple fix as looks like the null check in FederationRMFailoverProxyProvider::closeInternal was at wrong level.

          People

          • Assignee:
            subru Subru Krishnan
            Reporter:
            asuresh Arun Suresh
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development