Details
-
Bug
-
Status: Resolved
-
Trivial
-
Resolution: Fixed
-
3.0.0-alpha4
-
Reviewed
Description
The expected value should come before the actual value. It would be nice to add some assert messages as well.
Attachments
Attachments
- YARN-6878.001.patch
- 7 kB
- Sen Zhao
- YARN-6878.002.patch
- 7 kB
- Sen Zhao
- YARN-6878.003.patch
- 7 kB
- Sen Zhao
Activity
Hadoop QA
added a comment -
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 19s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
trunk Compile Tests | |||
+1 | mvninstall | 15m 28s | trunk passed |
+1 | compile | 0m 38s | trunk passed |
+1 | checkstyle | 0m 30s | trunk passed |
+1 | mvnsite | 0m 44s | trunk passed |
+1 | findbugs | 1m 10s | trunk passed |
+1 | javadoc | 0m 24s | trunk passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 39s | the patch passed |
+1 | compile | 0m 35s | the patch passed |
+1 | javac | 0m 35s | the patch passed |
-0 | checkstyle | 0m 26s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 196 unchanged - 8 fixed = 198 total (was 204) |
+1 | mvnsite | 0m 44s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 1m 18s | the patch passed |
+1 | javadoc | 0m 21s | the patch passed |
Other Tests | |||
-1 | unit | 45m 29s | hadoop-yarn-server-resourcemanager in the patch failed. |
+1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
70m 20s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:71bbb86 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887033/YARN-6878.001.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux ba28737e77b5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / c92c1d5 |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC1 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/17453/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
unit | https://builds.apache.org/job/PreCommit-YARN-Build/17453/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17453/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17453/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Hadoop QA
added a comment -
-1 overall
Vote
Subsystem
Runtime
Comment
0
reexec
0m 19s
Docker mode activated.
Prechecks
+1
@author
0m 0s
The patch does not contain any @author tags.
+1
test4tests
0m 0s
The patch appears to include 1 new or modified test files.
trunk Compile Tests
+1
mvninstall
15m 28s
trunk passed
+1
compile
0m 38s
trunk passed
+1
checkstyle
0m 30s
trunk passed
+1
mvnsite
0m 44s
trunk passed
+1
findbugs
1m 10s
trunk passed
+1
javadoc
0m 24s
trunk passed
Patch Compile Tests
+1
mvninstall
0m 39s
the patch passed
+1
compile
0m 35s
the patch passed
+1
javac
0m 35s
the patch passed
-0
checkstyle
0m 26s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 196 unchanged - 8 fixed = 198 total (was 204)
+1
mvnsite
0m 44s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
findbugs
1m 18s
the patch passed
+1
javadoc
0m 21s
the patch passed
Other Tests
-1
unit
45m 29s
hadoop-yarn-server-resourcemanager in the patch failed.
+1
asflicense
0m 14s
The patch does not generate ASF License warnings.
70m 20s
Reason
Tests
Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
Subsystem
Report/Notes
Docker
Image:yetus/hadoop:71bbb86
JIRA Issue
YARN-6878
JIRA Patch URL
https://issues.apache.org/jira/secure/attachment/12887033/YARN-6878.001.patch
Optional Tests
asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
uname
Linux ba28737e77b5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision
trunk / c92c1d5
Default Java
1.8.0_144
findbugs
v3.1.0-RC1
checkstyle
https://builds.apache.org/job/PreCommit-YARN-Build/17453/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
unit
https://builds.apache.org/job/PreCommit-YARN-Build/17453/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
Test Results
https://builds.apache.org/job/PreCommit-YARN-Build/17453/testReport/
modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output
https://builds.apache.org/job/PreCommit-YARN-Build/17453/console
Powered by
Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org
This message was automatically generated.
I find other wrong order about asserEqual() in TestCapacityScheduler and some unused import. So I submit patch 001 to fix these.
Patch 002 to fix the checkstyle.
Sen Zhao
added a comment - - edited I find other wrong order about asserEqual() in TestCapacityScheduler and some unused import. So I submit patch 001 to fix these.
Patch 002 to fix the checkstyle.
Daniel Templeton
added a comment -
Looks great. One issue:
Assert.assertEquals("Available Resource Memory Size should be 1GB", 0, availableResource.getMemorySize()); Assert.assertEquals("Available Resource Memory Size should be 1GB", 0, availableResource.getVirtualCores());
The tests and the messages don't agree on the correct value.
Daniel Templeton
added a comment - Looks great. One issue:
Assert.assertEquals( "Available Resource Memory Size should be 1GB" , 0,
availableResource.getMemorySize());
Assert.assertEquals( "Available Resource Memory Size should be 1GB" , 0,
availableResource.getVirtualCores());
The tests and the messages don't agree on the correct value.
Sen Zhao
added a comment - Oh, I did not notice this. I will fix it soon. Thanks, templedf
Hadoop QA
added a comment -
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 13s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
trunk Compile Tests | |||
+1 | mvninstall | 13m 57s | trunk passed |
+1 | compile | 0m 37s | trunk passed |
+1 | checkstyle | 0m 29s | trunk passed |
+1 | mvnsite | 0m 39s | trunk passed |
+1 | findbugs | 1m 1s | trunk passed |
+1 | javadoc | 0m 21s | trunk passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 34s | the patch passed |
+1 | compile | 0m 32s | the patch passed |
+1 | javac | 0m 32s | the patch passed |
+1 | checkstyle | 0m 28s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 196 unchanged - 8 fixed = 196 total (was 204) |
+1 | mvnsite | 0m 35s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 1m 18s | the patch passed |
+1 | javadoc | 0m 23s | the patch passed |
Other Tests | |||
-1 | unit | 45m 40s | hadoop-yarn-server-resourcemanager in the patch failed. |
+1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
68m 23s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:71bbb86 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887233/YARN-6878.003.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux f724fbf68d06 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / ae8f55b |
Default Java | 1.8.0_144 |
findbugs | v3.1.0-RC1 |
unit | https://builds.apache.org/job/PreCommit-YARN-Build/17469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17469/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17469/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Hadoop QA
added a comment -
-1 overall
Vote
Subsystem
Runtime
Comment
0
reexec
0m 13s
Docker mode activated.
Prechecks
+1
@author
0m 0s
The patch does not contain any @author tags.
+1
test4tests
0m 0s
The patch appears to include 1 new or modified test files.
trunk Compile Tests
+1
mvninstall
13m 57s
trunk passed
+1
compile
0m 37s
trunk passed
+1
checkstyle
0m 29s
trunk passed
+1
mvnsite
0m 39s
trunk passed
+1
findbugs
1m 1s
trunk passed
+1
javadoc
0m 21s
trunk passed
Patch Compile Tests
+1
mvninstall
0m 34s
the patch passed
+1
compile
0m 32s
the patch passed
+1
javac
0m 32s
the patch passed
+1
checkstyle
0m 28s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 196 unchanged - 8 fixed = 196 total (was 204)
+1
mvnsite
0m 35s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
findbugs
1m 18s
the patch passed
+1
javadoc
0m 23s
the patch passed
Other Tests
-1
unit
45m 40s
hadoop-yarn-server-resourcemanager in the patch failed.
+1
asflicense
0m 14s
The patch does not generate ASF License warnings.
68m 23s
Reason
Tests
Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
Subsystem
Report/Notes
Docker
Image:yetus/hadoop:71bbb86
JIRA Issue
YARN-6878
JIRA Patch URL
https://issues.apache.org/jira/secure/attachment/12887233/YARN-6878.003.patch
Optional Tests
asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
uname
Linux f724fbf68d06 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision
trunk / ae8f55b
Default Java
1.8.0_144
findbugs
v3.1.0-RC1
unit
https://builds.apache.org/job/PreCommit-YARN-Build/17469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
Test Results
https://builds.apache.org/job/PreCommit-YARN-Build/17469/testReport/
modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output
https://builds.apache.org/job/PreCommit-YARN-Build/17469/console
Powered by
Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org
This message was automatically generated.
Sen Zhao
added a comment -
The failed tests are unrelated. templedf, can you give me some advises about the latest patch?
Sen Zhao
added a comment - The failed tests are unrelated. templedf , can you give me some advises about the latest patch?
Daniel Templeton
added a comment - LGTM +1
Sen Zhao
added a comment - Thanks for your review, templedf
Daniel Templeton
added a comment - Thanks for the patch, Sen Zhao . Committed to trunk.
Hudson
added a comment -
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12952/)
YARN-6878. (templedf: rev 164a063e746e3a2704eaaa9a04a7707d363524c0)
- (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
Hudson
added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12952/ )
YARN-6878 . (templedf: rev 164a063e746e3a2704eaaa9a04a7707d363524c0)
(edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
Thanks Daniel! I'll try to fix this issue.