Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6871

Add additional deSelects params in RMWebServices#getAppReport

    Details

    • Hadoop Flags:
      Reviewed

      Description

      This jira tracks the effort to add additional deSelect params to the GetAppReport to make it lighter and faster.
      With the current one we are facing a scalability issues.
      E.g. with ~500 applications running the AppReport can reach up to 300MB in size due to the ResourceRequest in the AppInfo.

      Yarn RM will return the new result faster and it will use less compute cycles to create the report and it will improve the YARN RM and Client's performances.

      1. YARN-6871.proto.patch
        12 kB
        Tanuj Nayak
      2. YARN-6871.002.patch
        17 kB
        Tanuj Nayak
      3. YARN-6871.003.patch
        16 kB
        Tanuj Nayak
      4. YARN-6871.004.patch
        18 kB
        Tanuj Nayak
      5. YARN-6871.005.patch
        12 kB
        Tanuj Nayak
      6. YARN-6871.006.patch
        12 kB
        Tanuj Nayak
      7. YARN-6871.007.patch
        13 kB
        Tanuj Nayak
      8. YARN-6871.008.patch
        13 kB
        Tanuj Nayak
      9. YARN-6871.009.patch
        12 kB
        Tanuj Nayak
      10. YARN-6871-branch-2.v1.patch
        12 kB
        Tanuj Nayak
      11. YARN-6871-branch-2.v2.patch
        12 kB
        Tanuj Nayak
      12. YARN-6871-branch-2.v3.patch
        12 kB
        Tanuj Nayak

        Issue Links

          Activity

          Hide
          subru Subru Krishnan added a comment -

          Thanks Tanuj Nayak for the contribution and Giovanni Matteo Fumarola for the reviews.

          Sunil G, I went ahead and committed the branch-2 patch and cherry-picked also to branch-3.0 since you had +1ed.

          Show
          subru Subru Krishnan added a comment - Thanks Tanuj Nayak for the contribution and Giovanni Matteo Fumarola for the reviews. Sunil G , I went ahead and committed the branch-2 patch and cherry-picked also to branch-3.0 since you had +1ed.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Done.

          Show
          tanujnay Tanuj Nayak added a comment - Done.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 7m 56s branch-2 passed
          +1 compile 0m 35s branch-2 passed
          +1 checkstyle 0m 23s branch-2 passed
          +1 mvnsite 0m 40s branch-2 passed
          +1 findbugs 1m 13s branch-2 passed
          +1 javadoc 0m 25s branch-2 passed
                Patch Compile Tests
          +1 mvninstall 0m 34s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          +1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50)
          +1 mvnsite 0m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 31s the patch passed
          +1 javadoc 0m 26s the patch passed
                Other Tests
          -1 unit 45m 18s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          62m 41s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:eaf5c66
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12890550/YARN-6871-branch-2.v3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 5f839be25e0b 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / fa6b8fe
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17796/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17796/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17796/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 7m 56s branch-2 passed +1 compile 0m 35s branch-2 passed +1 checkstyle 0m 23s branch-2 passed +1 mvnsite 0m 40s branch-2 passed +1 findbugs 1m 13s branch-2 passed +1 javadoc 0m 25s branch-2 passed       Patch Compile Tests +1 mvninstall 0m 34s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed +1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50) +1 mvnsite 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 26s the patch passed       Other Tests -1 unit 45m 18s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 62m 41s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:eaf5c66 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12890550/YARN-6871-branch-2.v3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 5f839be25e0b 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / fa6b8fe Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/17796/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17796/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17796/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Tanuj Nayak please help to rebase branch-2 patch.

          Show
          sunilg Sunil G added a comment - Tanuj Nayak please help to rebase branch-2 patch.
          Hide
          sunilg Sunil G added a comment -

          Oops. Patch seems a rebase again. Tanuj Nayak please help to check.

          Show
          sunilg Sunil G added a comment - Oops. Patch seems a rebase again. Tanuj Nayak please help to check.
          Hide
          sunilg Sunil G added a comment -

          Other test failures are not related. So getting this to branch-2 as well.

          Show
          sunilg Sunil G added a comment - Other test failures are not related. So getting this to branch-2 as well.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Fixed

          Show
          tanujnay Tanuj Nayak added a comment - Fixed
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 7m 35s branch-2 passed
          +1 compile 0m 34s branch-2 passed
          +1 checkstyle 0m 23s branch-2 passed
          +1 mvnsite 0m 40s branch-2 passed
          +1 findbugs 1m 21s branch-2 passed
          +1 javadoc 0m 27s branch-2 passed
                Patch Compile Tests
          +1 mvninstall 0m 36s the patch passed
          +1 compile 0m 33s the patch passed
          +1 javac 0m 33s the patch passed
          +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50)
          +1 mvnsite 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 24s the patch passed
                Other Tests
          -1 unit 105m 18s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 1m 7s The patch does not generate ASF License warnings.
          123m 24s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
            hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
            hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
            hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA
            org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore
            org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:eaf5c66
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889640/YARN-6871-branch-2.v2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux a1c47d16c2ef 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / cba1891
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17697/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17697/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 7m 35s branch-2 passed +1 compile 0m 34s branch-2 passed +1 checkstyle 0m 23s branch-2 passed +1 mvnsite 0m 40s branch-2 passed +1 findbugs 1m 21s branch-2 passed +1 javadoc 0m 27s branch-2 passed       Patch Compile Tests +1 mvninstall 0m 36s the patch passed +1 compile 0m 33s the patch passed +1 javac 0m 33s the patch passed +1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50) +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 24s the patch passed       Other Tests -1 unit 105m 18s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 1m 7s The patch does not generate ASF License warnings. 123m 24s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter   hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMHA   org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore   org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService Subsystem Report/Notes Docker Image:yetus/hadoop:eaf5c66 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889640/YARN-6871-branch-2.v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux a1c47d16c2ef 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / cba1891 Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/17697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17697/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17697/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Sunil G, we don't necessarily need it beta but will be good to have in GA. Thanks.

          Show
          subru Subru Krishnan added a comment - Sunil G , we don't necessarily need it beta but will be good to have in GA. Thanks.
          Hide
          sunilg Sunil G added a comment -

          Test case failure seems related. Tanuj Nayak please help to check the same.

          Show
          sunilg Sunil G added a comment - Test case failure seems related. Tanuj Nayak please help to check the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 7m 11s branch-2 passed
          +1 compile 0m 30s branch-2 passed
          +1 checkstyle 0m 26s branch-2 passed
          +1 mvnsite 0m 35s branch-2 passed
          +1 findbugs 1m 43s branch-2 passed
          +1 javadoc 0m 40s branch-2 passed
                Patch Compile Tests
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 34s the patch passed
          +1 javac 0m 34s the patch passed
          +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 21s the patch passed
          +1 javadoc 0m 22s the patch passed
                Other Tests
          -1 unit 44m 21s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          61m 42s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:eaf5c66
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889361/YARN-6871-branch-2.v1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux ff0eb02d9ef9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c570dda
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17669/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17669/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 7m 11s branch-2 passed +1 compile 0m 30s branch-2 passed +1 checkstyle 0m 26s branch-2 passed +1 mvnsite 0m 35s branch-2 passed +1 findbugs 1m 43s branch-2 passed +1 javadoc 0m 40s branch-2 passed       Patch Compile Tests +1 mvninstall 0m 52s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 21s the patch passed +1 javadoc 0m 22s the patch passed       Other Tests -1 unit 44m 21s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 61m 42s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Subsystem Report/Notes Docker Image:yetus/hadoop:eaf5c66 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889361/YARN-6871-branch-2.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux ff0eb02d9ef9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c570dda Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/17669/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17669/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17669/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          tanujnay Tanuj Nayak added a comment -

          My apologies, attached branch2 patch with corrected naming.

          Show
          tanujnay Tanuj Nayak added a comment - My apologies, attached branch2 patch with corrected naming.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Tanuj Nayak for the patch. However, you have to rename (v9) in YARN-6871-branch-2.v1.patch since this patch will be apply in branch-2.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Tanuj Nayak for the patch. However, you have to rename (v9) in YARN-6871 -branch-2.v1.patch since this patch will be apply in branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 4m 44s YARN-6871 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889356/YARN-6871.009.patch
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17667/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 4m 44s YARN-6871 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889356/YARN-6871.009.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/17667/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12985 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12985/)
          YARN-6871. Add additional deSelects params in (sunilg: rev 8facf1f976d7e12a846f12baabf54be1b7a49f9d)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DeSelectFields.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12985 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12985/ ) YARN-6871 . Add additional deSelects params in (sunilg: rev 8facf1f976d7e12a846f12baabf54be1b7a49f9d) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DeSelectFields.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java
          Hide
          sunilg Sunil G added a comment -

          Committed to trunk. Please share branch-2 patch as compilation is failing.
          Subru Krishnan Tanuj Nayak are we looking to get this in beta.?

          Show
          sunilg Sunil G added a comment - Committed to trunk. Please share branch-2 patch as compilation is failing. Subru Krishnan Tanuj Nayak are we looking to get this in beta.?
          Hide
          sunilg Sunil G added a comment -

          Yes. Latest patch seems fine to me. I could commit tomorrow if there are no objections.

          Show
          sunilg Sunil G added a comment - Yes. Latest patch seems fine to me. I could commit tomorrow if there are no objections.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Giovanni Matteo Fumarola Sunil G Added v8 with the checkstyle warnings fixed. I don't think the failed test here is relevant to the patch.

          Show
          tanujnay Tanuj Nayak added a comment - Giovanni Matteo Fumarola Sunil G Added v8 with the checkstyle warnings fixed. I don't think the failed test here is relevant to the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 15m 1s trunk passed
          +1 compile 0m 38s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 findbugs 1m 6s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 37s the patch passed
          +1 compile 0m 34s the patch passed
          +1 javac 0m 34s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 52 unchanged - 1 fixed = 52 total (was 53)
          +1 mvnsite 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 13s the patch passed
          +1 javadoc 0m 20s the patch passed
                Other Tests
          -1 unit 49m 2s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          72m 52s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888446/YARN-6871.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eea571863220 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c71d137
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17585/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17585/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 1s trunk passed +1 compile 0m 38s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 39s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 52 unchanged - 1 fixed = 52 total (was 53) +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 13s the patch passed +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 49m 2s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 72m 52s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888446/YARN-6871.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eea571863220 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c71d137 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17585/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17585/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 12m 32s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 findbugs 0m 55s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 47m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          68m 2s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888185/YARN-6871.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eb558cefce04 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a12f09b
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17562/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17562/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 12m 32s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 0m 55s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 31s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 47m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 68m 2s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888185/YARN-6871.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eb558cefce04 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17562/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17562/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 55s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 38s trunk passed
          +1 findbugs 1m 0s trunk passed
          +1 javadoc 0m 24s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 52 unchanged - 1 fixed = 58 total (was 53)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 6s the patch passed
          +1 javadoc 0m 19s the patch passed
                Other Tests
          -1 unit 50m 7s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          72m 31s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888182/YARN-6871.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 519d2e1cf85f 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a12f09b
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17561/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17561/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17561/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17561/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 55s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 38s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 24s trunk passed       Patch Compile Tests +1 mvninstall 0m 33s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 52 unchanged - 1 fixed = 58 total (was 53) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 50m 7s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 72m 31s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888182/YARN-6871.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 519d2e1cf85f 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17561/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17561/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17561/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17561/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 12m 39s trunk passed
          +1 compile 0m 32s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 findbugs 0m 56s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 52 unchanged - 1 fixed = 58 total (was 53)
          +1 mvnsite 0m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 2s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 47m 36s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          68m 19s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Uninitialized read of timeouts in new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppInfo(ResourceManager, RMApp, Boolean, String, DeSelectFields) At AppInfo.java:new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppInfo(ResourceManager, RMApp, Boolean, String, DeSelectFields) At AppInfo.java:[line 301]
          Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
            hadoop.yarn.server.resourcemanager.TestRMHA
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiceAppsNodelabel



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888175/YARN-6871.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8a95b8bdc314 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a12f09b
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17559/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17559/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 12m 39s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 35s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 31s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 6 new + 52 unchanged - 1 fixed = 58 total (was 53) +1 mvnsite 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 2s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 47m 36s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 68m 19s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Uninitialized read of timeouts in new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppInfo(ResourceManager, RMApp, Boolean, String, DeSelectFields) At AppInfo.java:new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppInfo(ResourceManager, RMApp, Boolean, String, DeSelectFields) At AppInfo.java: [line 301] Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.TestRMHA   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation   hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiceAppsNodelabel Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888175/YARN-6871.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a95b8bdc314 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/17559/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17559/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/17559/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          +1 from my side as well. However looks like patch needs rebase. Kindly check.

          Show
          sunilg Sunil G added a comment - +1 from my side as well. However looks like patch needs rebase. Kindly check.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          +1 LGTM. Sunil G Can you review it?

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - +1 LGTM. Sunil G Can you review it?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 37s trunk passed
          +1 compile 0m 36s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 findbugs 1m 4s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 36s the patch passed
          +1 javac 0m 36s the patch passed
          +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65)
          +1 mvnsite 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 8s the patch passed
          +1 javadoc 0m 19s the patch passed
                Other Tests
          -1 unit 43m 12s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          66m 26s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880662/YARN-6871.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2fb1db2a4898 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0b67436
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16742/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16742/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16742/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 37s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 39s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 33s the patch passed +1 compile 0m 36s the patch passed +1 javac 0m 36s the patch passed +1 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65) +1 mvnsite 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 8s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 43m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 66m 26s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880662/YARN-6871.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2fb1db2a4898 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b67436 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16742/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16742/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16742/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Hey Sunil G, regarding the second point, the resource request assignment was originally done within another if clause controlled by the hasAccess variable. Moving the check on this assignment down would mean moving it out of this if clause. Is it fine if that happens?

          Show
          tanujnay Tanuj Nayak added a comment - Hey Sunil G , regarding the second point, the resource request assignment was originally done within another if clause controlled by the hasAccess variable. Moving the check on this assignment down would mean moving it out of this if clause. Is it fine if that happens?
          Hide
          sunilg Sunil G added a comment -

          Just took a quick scan, some more thoughts:

          1. deSelects params are using variable names from AppInfo DAO objects which is correct. But this patch is using appTimeouts instead of timeouts from AppInfo class. I think these need to be in sync. If we are planning the name change in AppInfo DAO object for timeouts, I think that also is fine. Looping Rohith Sharma K S for additional thoughts on same.
          2. Existing resource request skip check in AppInfo ctor could also be moved down with new changes so its easier to be together.
          Show
          sunilg Sunil G added a comment - Just took a quick scan, some more thoughts: deSelects params are using variable names from AppInfo DAO objects which is correct. But this patch is using appTimeouts instead of timeouts from AppInfo class. I think these need to be in sync. If we are planning the name change in AppInfo DAO object for timeouts , I think that also is fine. Looping Rohith Sharma K S for additional thoughts on same. Existing resource request skip check in AppInfo ctor could also be moved down with new changes so its easier to be together.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Tanuj Nayak for v3.
          Some feedback:

          • You added 2 test scenarios in testAppsQueryWithDeselects while you are adding 4 params. Please update the test.
          • You have a checkstyle warning: VisibilityModifier. Try to fix by convert it to private and add get and set methods.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Tanuj Nayak for v3. Some feedback: You added 2 test scenarios in testAppsQueryWithDeselects while you are adding 4 params. Please update the test. You have a checkstyle warning: VisibilityModifier . Try to fix by convert it to private and add get and set methods.
          Hide
          tanujnay Tanuj Nayak added a comment -

          All these failed/timed out tests seem to be working fine on my end. Is the patch related to these tests?

          Show
          tanujnay Tanuj Nayak added a comment - All these failed/timed out tests seem to be working fine on my end. Is the patch related to these tests?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 10s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 findbugs 0m 58s trunk passed
          +1 javadoc 0m 21s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 63 unchanged - 2 fixed = 64 total (was 65)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 14s the patch passed
          +1 javadoc 0m 19s the patch passed
                Other Tests
          -1 unit 46m 27s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          69m 0s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880539/YARN-6871.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fe967a4d2734 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 024c3ec
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16721/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16721/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16721/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16721/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 10s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 37s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -0 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 63 unchanged - 2 fixed = 64 total (was 65) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 14s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 46m 27s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 69m 0s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880539/YARN-6871.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fe967a4d2734 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 024c3ec Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16721/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16721/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16721/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16721/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Tanuj Nayak for the patch.
          Few comments:

          • I still think the formatting is not correctly set. Let me sync with you offline.
          • You have few checkstyle warnings. The [LineLength]s may be fixed with the correct formatting.
          • You have 2 unit tests that timed out. Please validate on your dev box that these tests pass successfully with your patch.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Tanuj Nayak for the patch. Few comments: I still think the formatting is not correctly set. Let me sync with you offline. You have few checkstyle warnings. The [LineLength] s may be fixed with the correct formatting. You have 2 unit tests that timed out. Please validate on your dev box that these tests pass successfully with your patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 16m 10s trunk passed
          +1 compile 0m 39s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 38s trunk passed
          +1 findbugs 1m 15s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 37s the patch passed
          +1 compile 0m 36s the patch passed
          +1 javac 0m 36s the patch passed
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 64 unchanged - 1 fixed = 69 total (was 65)
          +1 mvnsite 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 15s the patch passed
          +1 javadoc 0m 20s the patch passed
                Other Tests
          -1 unit 47m 26s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          73m 9s



          Reason Tests
          Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880230/YARN-6871.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 898b4030df32 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c5d256c
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16695/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16695/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16695/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 16m 10s trunk passed +1 compile 0m 39s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 38s trunk passed +1 findbugs 1m 15s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 36s the patch passed +1 javac 0m 36s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 64 unchanged - 1 fixed = 69 total (was 65) +1 mvnsite 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 47m 26s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 73m 9s Reason Tests Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880230/YARN-6871.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 898b4030df32 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c5d256c Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16695/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16695/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16695/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16695/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Added changes from Giovanni Matteo Fumarola's and Sunil G's comments.

          Show
          tanujnay Tanuj Nayak added a comment - Added changes from Giovanni Matteo Fumarola 's and Sunil G 's comments.
          Hide
          sunilg Sunil G added a comment -

          Thanks Tanuj Nayak

          Few general comments:

          1. Patch name is not as per standard. Please use <Jira_ID>.<indexNumber>.patch (something like YARN-6871.0001.patch)
          2. In DeSelectFields, improve java doc as few more entries are added.
          3. Currently {{ if(!deSelects)}} code is scattered in AppInfo. Its better to move all such code either to last of ctor and then comment it correctly. Better readability. Once we move to a common area, we can also see how we can avoid multiple if conditions if possible.
          Show
          sunilg Sunil G added a comment - Thanks Tanuj Nayak Few general comments: Patch name is not as per standard. Please use <Jira_ID>.<indexNumber>.patch (something like YARN-6871 .0001.patch) In DeSelectFields, improve java doc as few more entries are added. Currently {{ if(!deSelects)}} code is scattered in AppInfo. Its better to move all such code either to last of ctor and then comment it correctly. Better readability. Once we move to a common area, we can also see how we can avoid multiple if conditions if possible.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 15m 47s trunk passed
          +1 compile 0m 36s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 42s trunk passed
          +1 findbugs 1m 8s trunk passed
          +1 javadoc 0m 23s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 40s the patch passed
          +1 compile 0m 36s the patch passed
          -1 javac 0m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 46 unchanged - 1 fixed = 51 total (was 47)
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 7s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 42m 30s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          67m 0s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6871
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880085/YARN-6871.proto.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 52d71e33e536 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 79df1e7
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16673/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16673/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 47s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 42s trunk passed +1 findbugs 1m 8s trunk passed +1 javadoc 0m 23s trunk passed       Patch Compile Tests +1 mvninstall 0m 40s the patch passed +1 compile 0m 36s the patch passed -1 javac 0m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 5 new + 46 unchanged - 1 fixed = 51 total (was 47) +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 7s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 42m 30s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 67m 0s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6871 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880085/YARN-6871.proto.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52d71e33e536 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79df1e7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16673/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16673/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16673/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Tanuj Nayak for the patch.
          Few starting feedback:

          • You have to set up in your eclipse/intelJ the formatter to use hadoop formatter.
          • You add an useless import sun.security.krb5.internal.crypto.Des;. Please remove it.
          • Try to improve the comment in DeSelectFields.
          • Let add a test for each field. Check how they did in YARN-6820.
          • For timeout param, you have to skip the entire {{if (applicationTimeouts.isEmpty()) }}.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Tanuj Nayak for the patch. Few starting feedback: You have to set up in your eclipse/intelJ the formatter to use hadoop formatter. You add an useless import sun.security.krb5.internal.crypto.Des; . Please remove it. Try to improve the comment in DeSelectFields . Let add a test for each field. Check how they did in YARN-6820 . For timeout param, you have to skip the entire {{if (applicationTimeouts.isEmpty()) }}.
          Hide
          tanujnay Tanuj Nayak added a comment -

          Uploaded proto. From an offline discussion with @Giovanni Matteo Fumarola, we decided to start with 4 params: appNodeLabelExpression, amNodeLabelExpression, resourceInfo and timeouts.

          Show
          tanujnay Tanuj Nayak added a comment - Uploaded proto. From an offline discussion with @Giovanni Matteo Fumarola, we decided to start with 4 params: appNodeLabelExpression, amNodeLabelExpression, resourceInfo and timeouts.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited

          Good feedback Subru Krishnan and good work on YARN-6280 Lantao Jin/Sunil G.
          Let me update the title and the description.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited Good feedback Subru Krishnan and good work on YARN-6280 Lantao Jin / Sunil G . Let me update the title and the description.
          Hide
          sunilg Sunil G added a comment -

          Yes Subru Krishnan. You could use "deSelects=resourceRequest" for getApps/getApp and it will make your REST response lighter. Now if more attributes are needed to be skipped, deSelects is designed in such a way that it can support comma separated attributes. I think it will be better if we use thats as mentioned by Subru.

          Show
          sunilg Sunil G added a comment - Yes Subru Krishnan . You could use "deSelects=resourceRequest" for getApps/getApp and it will make your REST response lighter. Now if more attributes are needed to be skipped, deSelects is designed in such a way that it can support comma separated attributes. I think it will be better if we use thats as mentioned by Subru.
          Hide
          subru Subru Krishnan added a comment - - edited

          Giovanni Matteo Fumarola, +1 on the proposal. Can we extend the generic deSelects param introduced in YARN-6280 to achieve the same?

          Lantao Jin/Sunil G, thoughts?

          Show
          subru Subru Krishnan added a comment - - edited Giovanni Matteo Fumarola , +1 on the proposal. Can we extend the generic deSelects param introduced in YARN-6280 to achieve the same? Lantao Jin / Sunil G , thoughts?

            People

            • Assignee:
              tanujnay Tanuj Nayak
              Reporter:
              giovanni.fumarola Giovanni Matteo Fumarola
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development