Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6832

Tests use assertTrue(....equals(...)) instead of assertEquals()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: test
    • Labels:
      None
    1. YARN-6832.001.patch
      25 kB
      Daniel Templeton
    2. YARN-6832.branch-2.001.patch
      18 kB
      Daniel Templeton

      Activity

      Hide
      yufeigu Yufei Gu added a comment -

      Committed to branch-2.

      Show
      yufeigu Yufei Gu added a comment - Committed to branch-2.
      Hide
      templedf Daniel Templeton added a comment -

      Here's a branch-2 patch.

      Show
      templedf Daniel Templeton added a comment - Here's a branch-2 patch.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12111 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12111/)
      YARN-6832. Tests use assertTrue(....equals(...)) instead of (yufei: rev c617fe02b3686f0d91c3f81acf9bccd8290c59b7)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsHandlerImpl.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerUtils.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerDynamicBehavior.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationInputValidator.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithXFSFilter.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestYarnVersionInfo.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12111 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12111/ ) YARN-6832 . Tests use assertTrue(....equals(...)) instead of (yufei: rev c617fe02b3686f0d91c3f81acf9bccd8290c59b7) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsHandlerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerDynamicBehavior.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationInputValidator.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/webapp/TestRMWithXFSFilter.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestYarnVersionInfo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java
      Hide
      yufeigu Yufei Gu added a comment -

      Thanks for the patch, Daniel Templeton. Thanks for the review Maya Wexler. Committed to trunk. It does't apply to branch-2. Do you need a branch-2 version?

      Show
      yufeigu Yufei Gu added a comment - Thanks for the patch, Daniel Templeton . Thanks for the review Maya Wexler . Committed to trunk. It does't apply to branch-2. Do you need a branch-2 version?
      Hide
      yufeigu Yufei Gu added a comment -

      +1

      Show
      yufeigu Yufei Gu added a comment - +1
      Hide
      maya Maya Wexler added a comment -

      +1 (non-binding)

      I verified that all of the test clauses are still valid. Code looks cleaner with assertEquals().

      Show
      maya Maya Wexler added a comment - +1 (non-binding) I verified that all of the test clauses are still valid. Code looks cleaner with assertEquals().
      Hide
      templedf Daniel Templeton added a comment -

      Findbugs issues are unrelated.

      Show
      templedf Daniel Templeton added a comment - Findbugs issues are unrelated.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 18s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
            trunk Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for branch
      +1 mvninstall 13m 32s trunk passed
      +1 compile 8m 33s trunk passed
      +1 checkstyle 0m 57s trunk passed
      +1 mvnsite 2m 45s trunk passed
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
      -1 findbugs 0m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 5 extant Findbugs warnings.
      +1 javadoc 2m 4s trunk passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 2m 2s the patch passed
      +1 compile 5m 19s the patch passed
      +1 javac 5m 19s the patch passed
      +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 487 unchanged - 6 fixed = 487 total (was 493)
      +1 mvnsite 2m 57s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
      +1 findbugs 4m 30s the patch passed
      +1 javadoc 2m 2s the patch passed
            Other Tests
      +1 unit 2m 33s hadoop-yarn-common in the patch passed.
      +1 unit 13m 17s hadoop-yarn-server-nodemanager in the patch passed.
      +1 unit 44m 39s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 unit 20m 11s hadoop-yarn-client in the patch passed.
      +1 unit 4m 58s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
      +1 asflicense 0m 41s The patch does not generate ASF License warnings.
      144m 10s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6832
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877643/YARN-6832.001.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 3f26cde9559b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / b0e78ae
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16469/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16469/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.       trunk Compile Tests 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 13m 32s trunk passed +1 compile 8m 33s trunk passed +1 checkstyle 0m 57s trunk passed +1 mvnsite 2m 45s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests -1 findbugs 0m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 5 extant Findbugs warnings. +1 javadoc 2m 4s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 5m 19s the patch passed +1 javac 5m 19s the patch passed +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 487 unchanged - 6 fixed = 487 total (was 493) +1 mvnsite 2m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests +1 findbugs 4m 30s the patch passed +1 javadoc 2m 2s the patch passed       Other Tests +1 unit 2m 33s hadoop-yarn-common in the patch passed. +1 unit 13m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 44m 39s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 20m 11s hadoop-yarn-client in the patch passed. +1 unit 4m 58s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 144m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6832 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877643/YARN-6832.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3f26cde9559b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0e78ae Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16469/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16469/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16469/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

        People

        • Assignee:
          templedf Daniel Templeton
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development