Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6819

Application report fails if app rejected due to nodesize

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In YARN-5006 application rejected when nodesize limit is exceeded. FinalSavingTransition stateBeforeFinalSaving not set after skipping save to store which causes application report failure

      1. YARN-6819.001.patch
        2 kB
        Bibin A Chundatt
      2. YARN-6819.002.patch
        9 kB
        Bibin A Chundatt
      3. YARN-6819.003.patch
        9 kB
        Bibin A Chundatt
      4. YARN-6819.004.patch
        9 kB
        Bibin A Chundatt

        Issue Links

          Activity

          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Also we could modify second if to else if in RMAppImpl.createApplicationState().

          Show
          Naganarasimha Naganarasimha G R added a comment - Also we could modify second if to else if in RMAppImpl.createApplicationState() .
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks Bibin A Chundatt for the patch..

          I see many potential issue after YARN-5006 which are not handled gracefully. Can you confirm all of these with UT/FT test cases?

          1. It looks like for rejected app, state transition is not complete. The application will remain final_saving state only. Final state is not updated!
          2. Since state transition is not complete, the application finish time will not be updated.

          Comments on the patch

          1. Can you add proper log message with reason. The current log message bit confusing at least for me.
          2. Add a FT test case to check proper transition is happened. And also verify with application report for this app.
          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks Bibin A Chundatt for the patch.. I see many potential issue after YARN-5006 which are not handled gracefully. Can you confirm all of these with UT/FT test cases? It looks like for rejected app, state transition is not complete. The application will remain final_saving state only. Final state is not updated! Since state transition is not complete, the application finish time will not be updated. Comments on the patch Can you add proper log message with reason. The current log message bit confusing at least for me. Add a FT test case to check proper transition is happened. And also verify with application report for this app.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you Rohith Sharma K S
          Handled all mentioned scenarios and added FT for the same.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you Rohith Sharma K S Handled all mentioned scenarios and added FT for the same.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 53s trunk passed
          +1 compile 0m 35s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 42s trunk passed
          +1 findbugs 1m 9s trunk passed
          +1 javadoc 0m 26s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 38s the patch passed
          +1 compile 0m 35s the patch passed
          +1 javac 0m 35s the patch passed
          -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208)
          +1 mvnsite 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 4s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 43m 0s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          66m 54s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6819
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877136/YARN-6819.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux af1ca81aaa55 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 945c095
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16425/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16425/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16425/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16425/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 53s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 42s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 26s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 0m 35s the patch passed +1 javac 0m 35s the patch passed -0 checkstyle 0m 26s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208) +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 4s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 43m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 66m 54s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6819 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877136/YARN-6819.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux af1ca81aaa55 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 945c095 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16425/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16425/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16425/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16425/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          TestDelegationTokenRenewer locally its running fine looks like random issue.
          Will correct checkstyle issue in next patch after review.

          Show
          bibinchundatt Bibin A Chundatt added a comment - TestDelegationTokenRenewer locally its running fine looks like random issue. Will correct checkstyle issue in next patch after review.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          There are some other un covered issues with YARN-5006. Created a JIRA YARN-6825

          Show
          rohithsharma Rohith Sharma K S added a comment - There are some other un covered issues with YARN-5006 . Created a JIRA YARN-6825
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 lgtm, would mind fixing checkstyle which is fixable?

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 lgtm, would mind fixing checkstyle which is fixable?
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you Rohith Sharma K S for review .Attaching patch after handling checkstyle

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you Rohith Sharma K S for review .Attaching patch after handling checkstyle
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 30s trunk passed
          +1 compile 0m 34s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 22s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 20s the patch passed
                Other Tests
          -1 unit 42m 38s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          64m 25s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6819
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877455/YARN-6819.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b44bb2a4acdd 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 06ece48
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/16456/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16456/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16456/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 30s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 35s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 22s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 42m 38s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 64m 25s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6819 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877455/YARN-6819.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b44bb2a4acdd 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 06ece48 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16456/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16456/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16456/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          A minor nit.
          APP_SAVE_REJECTED could be named as APP_SAVE_FAILED. Since its a store operation, its better to inform or handle as failure than a rejection.

          Show
          sunilg Sunil G added a comment - A minor nit. APP_SAVE_REJECTED could be named as APP_SAVE_FAILED . Since its a store operation, its better to inform or handle as failure than a rejection.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Sunil G
          FAILED more like attempted then FAILED due to some issue. Here we are preventing the FAILURE case by rejecting before saving.
          I would prefer REJECTED by store. Is it a mandatory fix or suggestion??

          Show
          bibinchundatt Bibin A Chundatt added a comment - Sunil G FAILED more like attempted then FAILED due to some issue. Here we are preventing the FAILURE case by rejecting before saving. I would prefer REJECTED by store. Is it a mandatory fix or suggestion??
          Hide
          sunilg Sunil G added a comment -

          Bibin A Chundatt

          Is it a mandatory fix or suggestion??

          Sorry. I didnt get your point. To add more clarity, lemme try to rephrase my point again. Usually a store or similar entity does not accept or reject any op. Its usually said as saved or failure to save. Hence I coined that term as a failure. If its an authorizing entity, similar to RM, I guess accept or reject apps/requests/connections make more meaning.

          Show
          sunilg Sunil G added a comment - Bibin A Chundatt Is it a mandatory fix or suggestion?? Sorry. I didnt get your point. To add more clarity, lemme try to rephrase my point again. Usually a store or similar entity does not accept or reject any op. Its usually said as saved or failure to save. Hence I coined that term as a failure. If its an authorizing entity, similar to RM, I guess accept or reject apps/requests/connections make more meaning.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          If its an authorizing entity, similar to RM, I guess accept or reject apps/requests/connections make more meaning.

          In the current CS code when limit is reached APP_REJECTED event is triggered which is not an authorizing entity, thats the reason named APP_SAVE_REJECTED in same pattern.

          Show
          bibinchundatt Bibin A Chundatt added a comment - If its an authorizing entity, similar to RM, I guess accept or reject apps/requests/connections make more meaning. In the current CS code when limit is reached APP_REJECTED event is triggered which is not an authorizing entity, thats the reason named APP_SAVE_REJECTED in same pattern.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Attaching patch handling comments from Sunil G

          Show
          bibinchundatt Bibin A Chundatt added a comment - Attaching patch handling comments from Sunil G
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 48s trunk passed
          +1 compile 0m 39s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 41s trunk passed
          +1 findbugs 1m 13s trunk passed
          +1 javadoc 0m 26s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 41s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208)
          +1 mvnsite 0m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 15s the patch passed
          +1 javadoc 0m 22s the patch passed
                Other Tests
          +1 unit 44m 4s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          67m 31s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6819
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877781/YARN-6819.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 64d6edfb5566 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0b7afc0
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16478/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16478/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 48s trunk passed +1 compile 0m 39s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 41s trunk passed +1 findbugs 1m 13s trunk passed +1 javadoc 0m 26s trunk passed       Patch Compile Tests +1 mvninstall 0m 41s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208) +1 mvnsite 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 22s the patch passed       Other Tests +1 unit 44m 4s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 67m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6819 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877781/YARN-6819.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 64d6edfb5566 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b7afc0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16478/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16478/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16478/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 lgtm, committing shortly

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 lgtm, committing shortly
          Hide
          sunilg Sunil G added a comment -

          +1

          Show
          sunilg Sunil G added a comment - +1
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          committed to trunk and branch-2! thanks Bibin A Chundatt for the patch and Sunil G for the review

          Show
          rohithsharma Rohith Sharma K S added a comment - committed to trunk and branch-2! thanks Bibin A Chundatt for the patch and Sunil G for the review
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12028 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12028/)
          YARN-6819. Application report fails if app rejected due to nodesize. (rohithsharmaks: rev 845c4e52bdd579a24df5dbba7477b0ebf2fa16f1)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppEventType.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppEvent.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12028 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12028/ ) YARN-6819 . Application report fails if app rejected due to nodesize. (rohithsharmaks: rev 845c4e52bdd579a24df5dbba7477b0ebf2fa16f1) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppEventType.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppEvent.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you Sunil G and Rohith Sharma K S for review and commit

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you Sunil G and Rohith Sharma K S for review and commit

            People

            • Assignee:
              bibinchundatt Bibin A Chundatt
              Reporter:
              bibinchundatt Bibin A Chundatt
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development