Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6779

DominantResourceFairnessPolicy.DominantResourceFairnessComparator.calculateShares() should be @VisibleForTesting

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: fairscheduler
    • Labels:
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12051 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12051/)
      YARN-6779. (templedf: rev bb30bd3771442df253cbe55c448379580bd5ad07)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/DominantResourceFairnessPolicy.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12051 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12051/ ) YARN-6779 . (templedf: rev bb30bd3771442df253cbe55c448379580bd5ad07) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/DominantResourceFairnessPolicy.java
      Hide
      Cyl Yeliang Cang added a comment -

      Thank you for your review, Daniel Templeton!

      Show
      Cyl Yeliang Cang added a comment - Thank you for your review, Daniel Templeton !
      Hide
      templedf Daniel Templeton added a comment -

      Thanks for the patch, Yeliang Cang. Committed to trunk and branch-2.

      Show
      templedf Daniel Templeton added a comment - Thanks for the patch, Yeliang Cang . Committed to trunk and branch-2.
      Hide
      templedf Daniel Templeton added a comment -

      +1 LGTM

      Show
      templedf Daniel Templeton added a comment - +1 LGTM
      Hide
      Cyl Yeliang Cang added a comment -

      Hi, Daniel Templeton, I submit a patch as you suggest. Please check it out, thank you!

      Show
      Cyl Yeliang Cang added a comment - Hi, Daniel Templeton , I submit a patch as you suggest. Please check it out, thank you!

        People

        • Assignee:
          Cyl Yeliang Cang
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development