Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6778

In ResourceWeights, weights and setWeights() should be final

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: scheduler
    • Labels:
    1. YARN-6778.001.patch
      1 kB
      Daniel Templeton

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 14s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
            trunk Compile Tests
      +1 mvninstall 13m 37s trunk passed
      +1 compile 0m 34s trunk passed
      +1 checkstyle 0m 26s trunk passed
      +1 mvnsite 0m 36s trunk passed
      +1 findbugs 1m 1s trunk passed
      +1 javadoc 0m 21s trunk passed
            Patch Compile Tests
      +1 mvninstall 0m 34s the patch passed
      +1 compile 0m 34s the patch passed
      +1 javac 0m 34s the patch passed
      +1 checkstyle 0m 22s the patch passed
      +1 mvnsite 0m 35s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 9s the patch passed
      +1 javadoc 0m 19s the patch passed
            Other Tests
      -1 unit 42m 25s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 17s The patch does not generate ASF License warnings.
      64m 17s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
        hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6778
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876336/YARN-6778.001.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 34f4d5c35ab3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / ba5b056
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      unit https://builds.apache.org/job/PreCommit-YARN-Build/16345/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16345/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16345/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 37s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 36s trunk passed +1 findbugs 1m 1s trunk passed +1 javadoc 0m 21s trunk passed       Patch Compile Tests +1 mvninstall 0m 34s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 19s the patch passed       Other Tests -1 unit 42m 25s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 64m 17s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6778 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876336/YARN-6778.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 34f4d5c35ab3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ba5b056 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16345/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16345/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16345/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Unit test failures are unrelated.

      Show
      templedf Daniel Templeton added a comment - Unit test failures are unrelated.
      Hide
      yufeigu Yufei Gu added a comment -

      Thanks Daniel Templeton for working on this. Method setWeights() is invoked not only in constructor, why we need it to be final?

      Show
      yufeigu Yufei Gu added a comment - Thanks Daniel Templeton for working on this. Method setWeights() is invoked not only in constructor, why we need it to be final?
      Hide
      templedf Daniel Templeton added a comment -

      It should be final because it is invoked in the constructor. Overridable methods called from a constructor can cause issues. See https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors.

      Show
      templedf Daniel Templeton added a comment - It should be final because it is invoked in the constructor. Overridable methods called from a constructor can cause issues. See https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors .
      Hide
      yufeigu Yufei Gu added a comment -

      Indeed. We should put this into style checking. +1 for this patch.

      Show
      yufeigu Yufei Gu added a comment - Indeed. We should put this into style checking. +1 for this patch.
      Hide
      yufeigu Yufei Gu added a comment -

      Committed to trunk and branch-2. Thanks Daniel Templeton.

      Show
      yufeigu Yufei Gu added a comment - Committed to trunk and branch-2. Thanks Daniel Templeton .

        People

        • Assignee:
          templedf Daniel Templeton
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development