This message was automatically generated.
Unit test failures are unrelated.
Thanks Daniel Templeton for working on this. Method setWeights() is invoked not only in constructor, why we need it to be final?
It should be final because it is invoked in the constructor. Overridable methods called from a constructor can cause issues. See https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors.
Indeed. We should put this into style checking. +1 for this patch.
Committed to trunk and branch-2. Thanks Daniel Templeton.