Committed to trunk and branch-2. Thanks Daniel Templeton.
Indeed. We should put this into style checking. +1 for this patch.
It should be final because it is invoked in the constructor. Overridable methods called from a constructor can cause issues. See https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors.
Thanks Daniel Templeton for working on this. Method setWeights() is invoked not only in constructor, why we need it to be final?
Unit test failures are unrelated.
This message was automatically generated.