Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6764

Simplify the logic in FairScheduler#attemptScheduling

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha3
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: fairscheduler
    • Labels:
      None

      Activity

      Hide
      djp Junping Du added a comment -

      Drop 2.8.2 in fix version given the patch only lands on trunk and branch-2.

      Show
      djp Junping Du added a comment - Drop 2.8.2 in fix version given the patch only lands on trunk and branch-2.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11981 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11981/)
      YARN-6764. Simplify the logic in FairScheduler#attemptScheduling. (yufei: rev 3de47ab5ea5cb75805a03010dc72e11b0cf6c173)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11981 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11981/ ) YARN-6764 . Simplify the logic in FairScheduler#attemptScheduling. (yufei: rev 3de47ab5ea5cb75805a03010dc72e11b0cf6c173) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
      Hide
      yufeigu Yufei Gu added a comment -

      Committed to trunk and branch-2. Thanks Karthik Kambatla for the review.

      Show
      yufeigu Yufei Gu added a comment - Committed to trunk and branch-2. Thanks Karthik Kambatla for the review.
      Hide
      kasha Karthik Kambatla added a comment -

      +1

      Show
      kasha Karthik Kambatla added a comment - +1
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 1m 1s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 13m 51s trunk passed
      +1 compile 0m 34s trunk passed
      +1 checkstyle 0m 26s trunk passed
      +1 mvnsite 0m 38s trunk passed
      +1 findbugs 1m 4s trunk passed
      +1 javadoc 0m 23s trunk passed
      +1 mvninstall 0m 37s the patch passed
      +1 compile 0m 34s the patch passed
      +1 javac 0m 34s the patch passed
      +1 checkstyle 0m 23s the patch passed
      +1 mvnsite 0m 34s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 7s the patch passed
      +1 javadoc 0m 19s the patch passed
      -1 unit 43m 23s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 18s The patch does not generate ASF License warnings.
      66m 29s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6764
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875806/YARN-6764.001.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux ac2eff1f5597 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 946dd25
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      unit https://builds.apache.org/job/PreCommit-YARN-Build/16303/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16303/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16303/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 51s trunk passed +1 compile 0m 34s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 38s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 7s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 43m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 66m 29s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6764 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875806/YARN-6764.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ac2eff1f5597 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 946dd25 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16303/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16303/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16303/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

        People

        • Assignee:
          yufeigu Yufei Gu
          Reporter:
          yufeigu Yufei Gu
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development