Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6759

Fix TestRMRestart.testRMRestartWaitForPreviousAMToFinish failure

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      java.lang.IllegalArgumentException: Total wait time should be greater than check interval time
      	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
      	at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:273)
      	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:618)
      

      refer https://builds.apache.org/job/PreCommit-YARN-Build/16229/testReport/org.apache.hadoop.yarn.server.resourcemanager/TestRMRestart/testRMRestartWaitForPreviousAMToFinish/ which ran for YARN-2919

      1. YARN-6759.001.patch
        2 kB
        Naganarasimha G R

        Issue Links

          Activity

          Hide
          Feng Yuan Feng Yuan added a comment -

          <code>
          final int maxRetry = 10;
          final RMApp rmAppForCheck = rmApp;
          GenericTestUtils.waitFor(
          new Supplier<Boolean>() {
          @Override
          public Boolean get()

          { return new Boolean(rmAppForCheck.getAppAttempts().size() == 4); }

          },
          100, maxRetry);
          <code>
          Maybe should "maxRetry * 100"

          Show
          Feng Yuan Feng Yuan added a comment - <code> final int maxRetry = 10; final RMApp rmAppForCheck = rmApp; GenericTestUtils.waitFor( new Supplier<Boolean>() { @Override public Boolean get() { return new Boolean(rmAppForCheck.getAppAttempts().size() == 4); } }, 100, maxRetry); <code> Maybe should " maxRetry * 100 "
          Hide
          bibinchundatt Bibin A Chundatt added a comment -
            public static void waitFor(Supplier<Boolean> check, int checkEveryMillis,
                int waitForMillis) throws TimeoutException, InterruptedException {
              Preconditions.checkNotNull(check, ERROR_MISSING_ARGUMENT);
              Preconditions.checkArgument(waitForMillis > checkEveryMillis,
                  ERROR_INVALID_ARGUMENT);
          

          Yes, "maxRetry * 100" should solve the problem

          Show
          bibinchundatt Bibin A Chundatt added a comment - public static void waitFor(Supplier< Boolean > check, int checkEveryMillis, int waitForMillis) throws TimeoutException, InterruptedException { Preconditions.checkNotNull(check, ERROR_MISSING_ARGUMENT); Preconditions.checkArgument(waitForMillis > checkEveryMillis, ERROR_INVALID_ARGUMENT); Yes, "maxRetry * 100" should solve the problem
          Hide
          eepayne Eric Payne added a comment -

          Please note that this is not just failing in trunk. It fails for me in branch-2 as well:

          java.lang.IllegalArgumentException: Total wait time should be greater than check interval time
          	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
          	at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:311)
          	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:613)
          
          Show
          eepayne Eric Payne added a comment - Please note that this is not just failing in trunk. It fails for me in branch-2 as well: java.lang.IllegalArgumentException: Total wait time should be greater than check interval time at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:311) at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:613)
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Attached the patch fixing the issue, Bibin A Chundatt can you please take a look

          Show
          Naganarasimha Naganarasimha G R added a comment - Attached the patch fixing the issue, Bibin A Chundatt can you please take a look
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 12m 32s trunk passed
          +1 compile 0m 31s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 32s trunk passed
          +1 findbugs 0m 56s trunk passed
          +1 javadoc 0m 18s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 28s the patch passed
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 16s the patch passed
                Other Tests
          +1 unit 43m 19s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          63m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877085/YARN-6759.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d543e6412835 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b61ab85
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16417/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16417/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 12m 32s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 32s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 18s trunk passed       Patch Compile Tests +1 mvninstall 0m 30s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 16s the patch passed       Other Tests +1 unit 43m 19s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 63m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877085/YARN-6759.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d543e6412835 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b61ab85 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16417/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16417/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          +1 Will commit it soon

          Show
          bibinchundatt Bibin A Chundatt added a comment - +1 Will commit it soon
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you Naganarasimha Garla for patch
          Committed to trunk and branch-2

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you Naganarasimha Garla for patch Committed to trunk and branch-2
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12007 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12007/)
          YARN-6759. Fix TestRMRestart.testRMRestartWaitForPreviousAMToFinish (bibinchundatt: rev 75c0220b4494dd4424a0c531e0bf0a763748dc62)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12007 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12007/ ) YARN-6759 . Fix TestRMRestart.testRMRestartWaitForPreviousAMToFinish (bibinchundatt: rev 75c0220b4494dd4424a0c531e0bf0a763748dc62) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMRestart.java

            People

            • Assignee:
              Naganarasimha Naganarasimha G R
              Reporter:
              Naganarasimha Naganarasimha G R
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development