Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6746

SchedulerUtils.checkResourceRequestMatchingNodePartition() is dead code

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha3
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: scheduler
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The function is unused. It also appears to be broken.

      1. YARN-6746.001.patch
        2 kB
        Deepti Sawhney
      2. YARN-6746.001.patch
        2 kB
        Deepti Sawhney
      3. YARN-6746.001.patch
        2 kB
        Deepti Sawhney
      4. YARN-6746.004.patch
        2 kB
        Deepti Sawhney

        Activity

        Hide
        sunilg Sunil G added a comment -

        Yes Daniel Templeton. Thanks for pointing out.
        We stopped using this after YARN-6040. We could remove this stale finction.

        Show
        sunilg Sunil G added a comment - Yes Daniel Templeton . Thanks for pointing out. We stopped using this after YARN-6040 . We could remove this stale finction.
        Hide
        Deepti.Sawhney Deepti Sawhney added a comment -

        Hello Daniel,

        I have removed the method. Kindly advise on further directions regarding
        Java, Maven. I would like to build the code before moving it to Jenkins.

        Regards,
        Deepti.

        Strictly speaking, you should build the project to make sure that nothing
        broke. To do that, you'll have to install Java and
        Maven. If you want to go there, let me know, and I'll point you to some
        more detailed instructions. The pre-commit job run by Jenkins will do that
        for you, though, so you can just leave it to Jenkins if you prefer.

        On Wed, Jun 28, 2017 at 3:31 PM, Daniel Templeton (JIRA) <jira@apache.org>

        Show
        Deepti.Sawhney Deepti Sawhney added a comment - Hello Daniel, I have removed the method. Kindly advise on further directions regarding Java, Maven. I would like to build the code before moving it to Jenkins. Regards, Deepti. Strictly speaking, you should build the project to make sure that nothing broke. To do that, you'll have to install Java and Maven. If you want to go there, let me know, and I'll point you to some more detailed instructions. The pre-commit job run by Jenkins will do that for you, though, so you can just leave it to Jenkins if you prefer. On Wed, Jun 28, 2017 at 3:31 PM, Daniel Templeton (JIRA) <jira@apache.org>
        Hide
        Deepti.Sawhney Deepti Sawhney added a comment -

        attached patch file - YARN-6746.001.patch

        Show
        Deepti.Sawhney Deepti Sawhney added a comment - attached patch file - YARN-6746 .001.patch
        Hide
        templedf Daniel Templeton added a comment -

        Patch looks fine. Would you mind removing the extra newline that you added?

        Looks like Jenkins is asleep at the wheel. I'll go kick it.

        Show
        templedf Daniel Templeton added a comment - Patch looks fine. Would you mind removing the extra newline that you added? Looks like Jenkins is asleep at the wheel. I'll go kick it.
        Hide
        Deepti.Sawhney Deepti Sawhney added a comment -

        attached new file without the extra line

        Show
        Deepti.Sawhney Deepti Sawhney added a comment - attached new file without the extra line
        Hide
        Deepti.Sawhney Deepti Sawhney added a comment -

        Submitted the patch without the newline.
        Also attaching here -->

        On Fri, Jun 30, 2017 at 4:28 PM, Daniel Templeton (JIRA) <jira@apache.org>

        Show
        Deepti.Sawhney Deepti Sawhney added a comment - Submitted the patch without the newline. Also attaching here --> On Fri, Jun 30, 2017 at 4:28 PM, Daniel Templeton (JIRA) <jira@apache.org>
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 39s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 findbugs 0m 54s trunk passed
        +1 javadoc 0m 19s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 0s the patch passed
        +1 javadoc 0m 18s the patch passed
        -1 unit 44m 46s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        65m 7s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6746
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875341/YARN-6746.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 35d6187cf9e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 147df30
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16289/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16289/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16289/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 39s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 34s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 44m 46s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 65m 7s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6746 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875341/YARN-6746.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 35d6187cf9e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 147df30 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16289/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16289/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16289/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 37s trunk passed
        +1 compile 0m 29s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 findbugs 0m 53s trunk passed
        +1 javadoc 0m 18s trunk passed
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 0s the patch passed
        +1 javadoc 0m 18s the patch passed
        -1 unit 44m 32s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        64m 40s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6746
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875341/YARN-6746.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 23d544061b90 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fa1aaee
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16291/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16291/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16291/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 37s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 32s trunk passed +1 findbugs 0m 53s trunk passed +1 javadoc 0m 18s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 44m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 64m 40s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6746 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875341/YARN-6746.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 23d544061b90 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa1aaee Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16291/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16291/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16291/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Deepti.Sawhney Deepti Sawhney added a comment -

        Patch created by "Deepti Sawhney" as per request.

        Show
        Deepti.Sawhney Deepti Sawhney added a comment - Patch created by "Deepti Sawhney" as per request.
        Hide
        templedf Daniel Templeton added a comment -

        LGTM 1. I'll commit it later.

        Show
        templedf Daniel Templeton added a comment - LGTM 1. I'll commit it later.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        1 mvninstall 13m 13s trunk passed
        1 compile 0m 32s trunk passed
        1 checkstyle 0m 22s trunk passed
        1 mvnsite 0m 34s trunk passed
        1 findbugs 1m 0s trunk passed
        1 javadoc 0m 20s trunk passed
        1 mvninstall 0m 33s the patch passed
        1 compile 0m 31s the patch passed
        1 javac 0m 31s the patch passed
        1 checkstyle 0m 21s the patch passed
        1 mvnsite 0m 34s the patch passed
        1 whitespace 0m 0s The patch has no whitespace issues.
        1 findbugs 1m 6s the patch passed
        1 javadoc 0m 18s the patch passed
        -1 unit 43m 39s hadoop-yarn-server-resourcemanager in the patch failed.
        1 asflicense 0m 18s The patch does not generate ASF License warnings.
        64m 55s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6746
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875951/YARN-6746.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 127b0488b3dc 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7576a68
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16312/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16312/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16312/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. 1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 1 mvninstall 13m 13s trunk passed 1 compile 0m 32s trunk passed 1 checkstyle 0m 22s trunk passed 1 mvnsite 0m 34s trunk passed 1 findbugs 1m 0s trunk passed 1 javadoc 0m 20s trunk passed 1 mvninstall 0m 33s the patch passed 1 compile 0m 31s the patch passed 1 javac 0m 31s the patch passed 1 checkstyle 0m 21s the patch passed 1 mvnsite 0m 34s the patch passed 1 whitespace 0m 0s The patch has no whitespace issues. 1 findbugs 1m 6s the patch passed 1 javadoc 0m 18s the patch passed -1 unit 43m 39s hadoop-yarn-server-resourcemanager in the patch failed. 1 asflicense 0m 18s The patch does not generate ASF License warnings. 64m 55s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6746 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875951/YARN-6746.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 127b0488b3dc 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7576a68 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16312/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16312/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/16312/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Deepti Sawhney. Committed to trunk and branch-2.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Deepti Sawhney . Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11978/)
        YARN-6746. SchedulerUtils.checkResourceRequestMatchingNodePartition() is (templedf: rev c5a0c38d8e1752031d1dd8bdd4a7a3894cf775cb)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11978/ ) YARN-6746 . SchedulerUtils.checkResourceRequestMatchingNodePartition() is (templedf: rev c5a0c38d8e1752031d1dd8bdd4a7a3894cf775cb) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java

          People

          • Assignee:
            Deepti.Sawhney Deepti Sawhney
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development