Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6719

Fix findbugs warnings in SLSCapacityScheduler.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 2.7.4, 2.8.2
    • Component/s: None
    • Labels:
      None

      Description

      There are 2 findbugs warnings in branch-2. https://builds.apache.org/job/PreCommit-HADOOP-Build/12560/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html

      Dm	Found reliance on default encoding in org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler.initMetrics(): new java.io.FileWriter(String)
      Bug type DM_DEFAULT_ENCODING (click for details) 
      In class org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler
      In method org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler.initMetrics()
      Called method new java.io.FileWriter(String)
      At SLSCapacityScheduler.java:[line 464]
      
      Dm	Found reliance on default encoding in new org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler$MetricsLogRunnable(SLSCapacityScheduler): new java.io.FileWriter(String)
      Bug type DM_DEFAULT_ENCODING (click for details) 
      In class org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler$MetricsLogRunnable
      In method new org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler$MetricsLogRunnable(SLSCapacityScheduler)
      Called method new java.io.FileWriter(String)
      At SLSCapacityScheduler.java:[line 669]
      
      1. YARN-6719-branch-2.01.patch
        2 kB
        Akira Ajisaka
      2. YARN-6719-branch-2.8-01.patch
        2 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch for branch-2.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch for branch-2.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The patch for branch-2.8 can be applied to branch-2.7 cleanly.

          Show
          ajisakaa Akira Ajisaka added a comment - The patch for branch-2.8 can be applied to branch-2.7 cleanly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 46s branch-2.8 passed
          +1 compile 0m 15s branch-2.8 passed with JDK v1.8.0_131
          +1 compile 0m 17s branch-2.8 passed with JDK v1.7.0_131
          +1 checkstyle 0m 15s branch-2.8 passed
          +1 mvnsite 0m 23s branch-2.8 passed
          -1 findbugs 0m 36s hadoop-tools/hadoop-sls in branch-2.8 has 2 extant Findbugs warnings.
          +1 javadoc 0m 13s branch-2.8 passed with JDK v1.8.0_131
          +1 javadoc 0m 15s branch-2.8 passed with JDK v1.7.0_131
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 12s the patch passed with JDK v1.8.0_131
          +1 javac 0m 12s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.7.0_131
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 42s hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 javadoc 0m 9s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_131
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          17m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d946387
          JIRA Issue YARN-6719
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873418/YARN-6719-branch-2.8-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 957dbab210b0 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / e47ec94
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16198/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16198/testReport/
          modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16198/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 46s branch-2.8 passed +1 compile 0m 15s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 17s branch-2.8 passed with JDK v1.7.0_131 +1 checkstyle 0m 15s branch-2.8 passed +1 mvnsite 0m 23s branch-2.8 passed -1 findbugs 0m 36s hadoop-tools/hadoop-sls in branch-2.8 has 2 extant Findbugs warnings. +1 javadoc 0m 13s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 15s branch-2.8 passed with JDK v1.7.0_131 +1 mvninstall 0m 16s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_131 +1 javac 0m 12s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_131 +1 javac 0m 15s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 javadoc 0m 9s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_131 +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 17m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:d946387 JIRA Issue YARN-6719 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873418/YARN-6719-branch-2.8-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 957dbab210b0 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / e47ec94 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16198/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16198/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/16198/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the patch Akira Ajisaka, Simple fix , patch LGTM ! Committing it shortly.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Akira Ajisaka , Simple fix , patch LGTM ! Committing it shortly.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the contribution Akira Ajisaka, Committed the patch to @ branch-2, branch-2.8 and branch-2.7

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution Akira Ajisaka , Committed the patch to @ branch-2, branch-2.8 and branch-2.7
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks!

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Updated CHANGES.txt in branch-2.7.

          Show
          ajisakaa Akira Ajisaka added a comment - Updated CHANGES.txt in branch-2.7.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for correcting the 2.7 commit Akira Ajisaka.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for correcting the 2.7 commit Akira Ajisaka .
          Hide
          zhz Zhe Zhang added a comment -

          Removed release-blocker label since it's already committed to branch-2.7

          Show
          zhz Zhe Zhang added a comment - Removed release-blocker label since it's already committed to branch-2.7

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development