Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6592 [Umbrella] Rich placement constraints in YARN
  3. YARN-6597

Add RMContainer recovery test to verify tag population in the AllocationTagsManager

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • None
    • None

    Description

      Each allocation can have a set of allocation tags associated to it.
      For example, an allocation can be marked as hbase, hbase-master, spark, etc.
      These allocation-tags are active in the cluster only while that container is active (from the moment it gets allocated until the moment it finishes its execution).
      This JIRA is responsible for storing and updating in the PlacementConstraintManager the active allocation tags in the cluster.

      Attachments

        1. YARN-6597-YARN-6592.001.patch
          6 kB
          Panagiotis Garefalakis

        Activity

          cheersyang Weiwei Yang added a comment -

          Is this JIRA still valid since YARN-7522 has already done?

          cheersyang Weiwei Yang added a comment - Is this JIRA still valid since YARN-7522 has already done?
          pgaref Panagiotis Garefalakis added a comment - - edited

          cheersyang
          YARN-7522 introduced AllocationTagManager component which is storing simple node to application-container mappings.
          YARN-7653 added support for node-group/rack to application-container mappings.

          I would like to keep this JIRA in order to efficiently manage container tags under all possible Container state transitions (EXPIRED, RELEASED, KILLED e.t.c). Currently we support only container allocation and completion states just as a proof of concept.
          Does it make sense?

          pgaref Panagiotis Garefalakis added a comment - - edited cheersyang YARN-7522 introduced AllocationTagManager component which is storing simple node to application-container mappings. YARN-7653 added support for node-group/rack to application-container mappings. I would like to keep this JIRA in order to efficiently manage container tags under all possible Container state transitions (EXPIRED, RELEASED, KILLED e.t.c). Currently we support only container allocation and completion states just as a proof of concept. Does it make sense?
          cheersyang Weiwei Yang added a comment -

          It makes sense, thanks pgaref.

          cheersyang Weiwei Yang added a comment - It makes sense, thanks pgaref .

          Currently all RMContainer transitions are taking care of their allocation Tags - keeping allocationTags manager up to date.

          RECOVER transition was not covered in the tests so I added an extra case and fixed some typos.

          asuresh cheersyang please take a look

          pgaref Panagiotis Garefalakis added a comment - Currently all RMContainer transitions are taking care of their allocation Tags - keeping allocationTags manager up to date. RECOVER transition was not covered in the tests so I added an extra case and fixed some typos. asuresh cheersyang please take a look
          asuresh Arun Suresh added a comment -

          Thanks pgaref, +1
          Will push this in after we merge with trunk.

          asuresh Arun Suresh added a comment - Thanks pgaref , +1 Will push this in after we merge with trunk.
          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 32s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                YARN-6592 Compile Tests
          +1 mvninstall 16m 36s YARN-6592 passed
          +1 compile 0m 40s YARN-6592 passed
          +1 checkstyle 0m 27s YARN-6592 passed
          +1 mvnsite 0m 43s YARN-6592 passed
          +1 shadedclient 10m 19s branch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 6s YARN-6592 passed
          +1 javadoc 0m 26s YARN-6592 passed
                Patch Compile Tests
          +1 mvninstall 0m 41s the patch passed
          +1 compile 0m 35s the patch passed
          +1 javac 0m 35s the patch passed
          +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 57 unchanged - 2 fixed = 57 total (was 59)
          +1 mvnsite 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 10m 31s patch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 11s the patch passed
          +1 javadoc 0m 23s the patch passed
                Other Tests
          -1 unit 61m 25s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 asflicense 0m 21s The patch generated 4 ASF License warnings.
          106m 52s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
          JIRA Issue YARN-6597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12907751/YARN-6597-YARN-6592.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 948139ab41a8 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision YARN-6592 / 13d37ce
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_151
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/19472/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/19472/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/19472/artifact/out/patch-asflicense-problems.txt
          Max. process+thread count 831 (vs. ulimit of 5000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/19472/console
          Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       YARN-6592 Compile Tests +1 mvninstall 16m 36s YARN-6592 passed +1 compile 0m 40s YARN-6592 passed +1 checkstyle 0m 27s YARN-6592 passed +1 mvnsite 0m 43s YARN-6592 passed +1 shadedclient 10m 19s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 6s YARN-6592 passed +1 javadoc 0m 26s YARN-6592 passed       Patch Compile Tests +1 mvninstall 0m 41s the patch passed +1 compile 0m 35s the patch passed +1 javac 0m 35s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 57 unchanged - 2 fixed = 57 total (was 59) +1 mvnsite 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 31s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 23s the patch passed       Other Tests -1 unit 61m 25s hadoop-yarn-server-resourcemanager in the patch failed. -1 asflicense 0m 21s The patch generated 4 ASF License warnings. 106m 52s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue YARN-6597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12907751/YARN-6597-YARN-6592.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 948139ab41a8 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision YARN-6592 / 13d37ce maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/19472/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/19472/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/19472/artifact/out/patch-asflicense-problems.txt Max. process+thread count 831 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/19472/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          asuresh Arun Suresh added a comment -

          Committed this, since its essentially a test case change. Thanks pgaref !!

          asuresh Arun Suresh added a comment - Committed this, since its essentially a test case change. Thanks pgaref !!
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13589/)
          YARN-6597. Add RMContainer recovery test to verify tag population in the (arun suresh: rev add993e26a3c96f77dfd42086f186a139966019e)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13589/ ) YARN-6597 . Add RMContainer recovery test to verify tag population in the (arun suresh: rev add993e26a3c96f77dfd42086f186a139966019e) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java

          People

            pgaref Panagiotis Garefalakis
            kkaranasos Konstantinos Karanasos
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: