Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6577

Remove unused ContainerLocalization classes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.3, 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      From 2.7.3 and 3.0.0-alpha2, the ContainerLocalization interface and the ContainerLocalizationImpl implementation class are of no use, and I recommend removing the useless interface and implementation classes

        Activity

        Hide
        linzhangbing ZhangBing Lin added a comment -

        Submit a patch!

        Show
        linzhangbing ZhangBing Lin added a comment - Submit a patch!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 55s trunk passed
        +1 compile 0m 29s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 27s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        -1 findbugs 0m 41s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 5 extant Findbugs warnings.
        +1 javadoc 0m 18s trunk passed
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 26s the patch passed
        +1 javac 0m 26s the patch passed
        +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 44s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        33m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6577
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867260/YARN-6577.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c982b00d4cb8 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 06ffeb8
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15890/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15890/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15890/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 55s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 16s trunk passed -1 findbugs 0m 41s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager in trunk has 5 extant Findbugs warnings. +1 javadoc 0m 18s trunk passed +1 mvninstall 0m 23s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 44s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 13m 9s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 33m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6577 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867260/YARN-6577.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c982b00d4cb8 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 06ffeb8 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15890/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15890/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15890/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Just delete the useless codes, no unit tests needed!

        Show
        linzhangbing ZhangBing Lin added a comment - Just delete the useless codes, no unit tests needed!
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Hi,Rohith Sharma K S,
        I can't change the Assignee to oneself also when submit theĀ YARN-6577.Please add me as contributor for Apache Hadoop.My account is ZhangBing Lin.
        Thanks
        ZhangBing Lin

        Show
        linzhangbing ZhangBing Lin added a comment - Hi, Rohith Sharma K S , I can't change the Assignee to oneself also when submit theĀ  YARN-6577 .Please add me as contributor for Apache Hadoop.My account is ZhangBing Lin. Thanks ZhangBing Lin
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        ZhangBing Lin added you as YARN contributor list. Feel free to assign JIRAs and contribute more. Appreciate your interest

        Show
        rohithsharma Rohith Sharma K S added a comment - ZhangBing Lin added you as YARN contributor list. Feel free to assign JIRAs and contribute more. Appreciate your interest
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Rohith Sharma K S,can you plz take a quick review?

        Show
        linzhangbing ZhangBing Lin added a comment - Rohith Sharma K S ,can you plz take a quick review?
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Akira Ajisaka,Can you plz take a quick review?

        Show
        linzhangbing ZhangBing Lin added a comment - Akira Ajisaka ,Can you plz take a quick review?
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 I committed this. Thanks ZhangBing Lin

        Show
        chris.douglas Chris Douglas added a comment - +1 I committed this. Thanks ZhangBing Lin
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Chris Douglas,Thank you for your review and commit!

        Show
        linzhangbing ZhangBing Lin added a comment - Chris Douglas ,Thank you for your review and commit!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11748 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11748/)
        YARN-6577. Remove unused ContainerLocalization classes. Contributed by (cdouglas: rev b23fcc86c670aa896151a2bd8878154d7bb45d13)

        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerLocalizationImpl.java
        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerLocalization.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11748 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11748/ ) YARN-6577 . Remove unused ContainerLocalization classes. Contributed by (cdouglas: rev b23fcc86c670aa896151a2bd8878154d7bb45d13) (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerLocalizationImpl.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerLocalization.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          People

          • Assignee:
            linzhangbing ZhangBing Lin
            Reporter:
            linzhangbing ZhangBing Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development