Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6519

Fix warnings from Spotbugs in hadoop-yarn-server-resourcemanager

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed

      Description

      There is 8 findbugs warning in hadoop-yarn-server-timelineservice since switched to spotbugs

      1. org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerQueueManager$1.compare(CSQueue, CSQueue) incorrectly handles float value
      2. org.apache.hadoop.yarn.server.resourcemanager.scheduler.NodeType.index field is public and mutable
      3. org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.EMPTY_CONTAINER_LIST is a mutable collection which should be package protected
      4. org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.EMPTY_CONTAINER_LIST is a mutable collection which should be package protected
      5. org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.queueMetrics is a mutable collection
      6. org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicy.cleanupStaledPreemptionCandidates(long) makes inefficient use of keySet iterator instead of entrySet iterator
      7. org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.transferStateFromAttempt(RMAppAttempt) makes inefficient use of keySet iterator instead of entrySet iterator
      8. org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSSchedulerNode.cleanupPreemptionList() makes inefficient use of keySet iterator instead of entrySet iterator

      See more from https://builds.apache.org/job/PreCommit-HADOOP-Build/12157/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html

        Attachments

        1. YARN-6519.001.patch
          17 kB
          Weiwei Yang
        2. YARN-6519.002.patch
          16 kB
          Weiwei Yang
        3. YARN-6519-branch-2.001.patch
          16 kB
          Weiwei Yang

          Issue Links

            Activity

              People

              • Assignee:
                cheersyang Weiwei Yang
                Reporter:
                cheersyang Weiwei Yang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: