Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6493

Print requested node partition in assignContainer logs

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.4, 2.6.6
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
    • Component/s: None
    • Labels:
      None

      Description

      It would be useful to have the node's partition when logging a container allocation, for tracking purposes.

      1. YARN-6493.003.patch
        2 kB
        Jonathan Hung
      2. YARN-6493-branch-2.8.003.patch
        2 kB
        Jonathan Hung
      3. YARN-6493-branch-2.7.002.patch
        2 kB
        Jonathan Hung
      4. YARN-6493-branch-2.8.002.patch
        2 kB
        Jonathan Hung
      5. YARN-6493.002.patch
        2 kB
        Jonathan Hung
      6. YARN-6493-branch-2.7.001.patch
        2 kB
        Jonathan Hung
      7. YARN-6493-branch-2.8.001.patch
        3 kB
        Jonathan Hung
      8. YARN-6493.001.patch
        1 kB
        Jonathan Hung

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Brahma Reddy Battula, thanks for the reminding, just updated.

        Show
        leftnoteasy Wangda Tan added a comment - Brahma Reddy Battula , thanks for the reminding, just updated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Wangda Tan can you please update the CHANGES.txt in branch-2.7?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Wangda Tan can you please update the CHANGES.txt in branch-2.7 ?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11766 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11766/)
        YARN-6493. Print requested node partition in assignContainer logs. (wangda: rev 8e0f83e49a8987cf45a72c8a9bb8587b86e4c0ed)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/AbstractContainerAllocator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11766 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11766/ ) YARN-6493 . Print requested node partition in assignContainer logs. (wangda: rev 8e0f83e49a8987cf45a72c8a9bb8587b86e4c0ed) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/AbstractContainerAllocator.java
        Hide
        jhung Jonathan Hung added a comment -

        Awesome, thanks Wangda Tan!

        Show
        jhung Jonathan Hung added a comment - Awesome, thanks Wangda Tan !
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk/branch-2/branch-2.7/branch-2.8. Thanks Jonathan Hung!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2/branch-2.7/branch-2.8. Thanks Jonathan Hung !
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Jonathan Hung, patch LGTM, +1. Will commit soon.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Jonathan Hung , patch LGTM, +1. Will commit soon.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 30s trunk passed
        +1 compile 0m 35s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 4s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 0m 35s the patch passed
        +1 javac 0m 35s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 11s the patch passed
        +1 javadoc 0m 22s the patch passed
        -1 unit 39m 58s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        63m 44s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6493
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868190/YARN-6493.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d2374fc1037c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c48f297
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15937/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15937/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15937/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 30s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 0m 35s the patch passed +1 javac 0m 35s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 11s the patch passed +1 javadoc 0m 22s the patch passed -1 unit 39m 58s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 63m 44s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6493 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868190/YARN-6493.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d2374fc1037c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c48f297 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/15937/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15937/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15937/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jhung Jonathan Hung added a comment -

        Thanks Wangda Tan, uploaded three patches (003 for trunk, 003 for branch-2.8, 002 for branch-2.7).

        Also added some logging in branch-2.8 in case allocatedContainer null.

        Show
        jhung Jonathan Hung added a comment - Thanks Wangda Tan , uploaded three patches (003 for trunk, 003 for branch-2.8, 002 for branch-2.7). Also added some logging in branch-2.8 in case allocatedContainer null.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Jonathan Hung for updating the patch, could you:
        1) Rename "partition" to "requestedPartition"?
        2) Could you add a null check for rmcontainer in the 2.8 patch? It should not be expected happe, however I don't want it kills RM by mistake.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Jonathan Hung for updating the patch, could you: 1) Rename "partition" to "requestedPartition"? 2) Could you add a null check for rmcontainer in the 2.8 patch? It should not be expected happe, however I don't want it kills RM by mistake.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 20m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 17s branch-2.8 passed
        +1 compile 0m 32s branch-2.8 passed with JDK v1.8.0_131
        +1 compile 0m 32s branch-2.8 passed with JDK v1.7.0_121
        +1 checkstyle 0m 18s branch-2.8 passed
        +1 mvnsite 0m 38s branch-2.8 passed
        +1 mvneclipse 0m 17s branch-2.8 passed
        +1 findbugs 1m 12s branch-2.8 passed
        +1 javadoc 0m 23s branch-2.8 passed with JDK v1.8.0_131
        +1 javadoc 0m 23s branch-2.8 passed with JDK v1.7.0_121
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 31s the patch passed with JDK v1.8.0_131
        +1 javac 0m 31s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_121
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 19s the patch passed
        +1 javadoc 0m 21s the patch passed with JDK v1.8.0_131
        +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121
        -1 unit 80m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        200m 58s



        Reason Tests
        JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5970e82
        JIRA Issue YARN-6493
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864843/YARN-6493-branch-2.8.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3aaab35337ee 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / c992cf6
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15929/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15929/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 17s branch-2.8 passed +1 compile 0m 32s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 32s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 18s branch-2.8 passed +1 mvnsite 0m 38s branch-2.8 passed +1 mvneclipse 0m 17s branch-2.8 passed +1 findbugs 1m 12s branch-2.8 passed +1 javadoc 0m 23s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 23s branch-2.8 passed with JDK v1.7.0_121 +1 mvninstall 0m 31s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_131 +1 javac 0m 31s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_121 +1 javac 0m 28s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 19s the patch passed +1 javadoc 0m 21s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121 -1 unit 80m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 200m 58s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption Subsystem Report/Notes Docker Image:yetus/hadoop:5970e82 JIRA Issue YARN-6493 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864843/YARN-6493-branch-2.8.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3aaab35337ee 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / c992cf6 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/15929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15929/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15929/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jhung Jonathan Hung added a comment -

        Hi Wangda Tan, does the latest patch look OK to you? Thanks!

        Show
        jhung Jonathan Hung added a comment - Hi Wangda Tan , does the latest patch look OK to you? Thanks!
        Hide
        jhung Jonathan Hung added a comment -

        I see...seems requested label is most useful, so that we can track demand per partition.

        In this case the branch-2.8 patch needs to be changed. Uploaded branch-2.8.002 for this.

        Show
        jhung Jonathan Hung added a comment - I see...seems requested label is most useful, so that we can track demand per partition. In this case the branch-2.8 patch needs to be changed. Uploaded branch-2.8.002 for this.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Jonathan Hung, not sure which partition you want to print, requested, or allocated, since non-exclusive node label could give you different partition other than you requested.

        Show
        leftnoteasy Wangda Tan added a comment - Jonathan Hung , not sure which partition you want to print, requested, or allocated, since non-exclusive node label could give you different partition other than you requested.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G, no, it will give you the original requested node label expression. It will be useful depends on the use case.

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , no, it will give you the original requested node label expression. It will be useful depends on the use case.
        Hide
        sunilg Sunil G added a comment -

        Wangda TanA quick question. For non-exclusive labels, RMContainer.getNodeLabelExpression will give correct label to which container is allocated, correct?

        Show
        sunilg Sunil G added a comment - Wangda Tan A quick question. For non-exclusive labels, RMContainer.getNodeLabelExpression will give correct label to which container is allocated, correct?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 16m 4s trunk passed
        +1 compile 0m 35s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        -1 findbugs 1m 4s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 8 extant Findbugs warnings.
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 12s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 41m 27s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        66m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ac17dc
        JIRA Issue YARN-6493
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864406/YARN-6493.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9cd9b46d2cde 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 667966c
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15704/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15704/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15704/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 16m 4s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 18s trunk passed -1 findbugs 1m 4s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 8 extant Findbugs warnings. +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 41m 27s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 66m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-6493 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864406/YARN-6493.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9cd9b46d2cde 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 667966c Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15704/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15704/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15704/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jhung Jonathan Hung added a comment -

        Oh, missed that. Good point, thanks Wangda Tan. Attached 002 for this.

        Show
        jhung Jonathan Hung added a comment - Oh, missed that. Good point, thanks Wangda Tan . Attached 002 for this.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Jonathan Hung, for trunk/branch-2 patch, I suggest to use RMContainer.getNodeLabelExpression. You don't need to read any fields from node. branch-2.7 patch is fine.

        Show
        leftnoteasy Wangda Tan added a comment - Jonathan Hung , for trunk/branch-2 patch, I suggest to use RMContainer.getNodeLabelExpression. You don't need to read any fields from node. branch-2.7 patch is fine.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 11m 46s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 18s branch-2.7 passed
        +1 compile 0m 24s branch-2.7 passed with JDK v1.8.0_121
        +1 compile 0m 28s branch-2.7 passed with JDK v1.7.0_121
        +1 checkstyle 0m 32s branch-2.7 passed
        +1 mvnsite 0m 37s branch-2.7 passed
        +1 mvneclipse 0m 20s branch-2.7 passed
        +1 findbugs 1m 11s branch-2.7 passed
        +1 javadoc 0m 20s branch-2.7 passed with JDK v1.8.0_121
        +1 javadoc 0m 23s branch-2.7 passed with JDK v1.7.0_121
        +1 mvninstall 0m 28s the patch passed
        +1 compile 0m 23s the patch passed with JDK v1.8.0_121
        +1 javac 0m 23s the patch passed
        +1 compile 0m 26s the patch passed with JDK v1.7.0_121
        +1 javac 0m 26s the patch passed
        -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 824 unchanged - 0 fixed = 825 total (was 824)
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 1172 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 31s The patch 73 line(s) with tabs.
        +1 findbugs 1m 14s the patch passed
        +1 javadoc 0m 16s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121
        -1 unit 50m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        132m 26s



        Reason Tests
        JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Issue YARN-6493
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864178/YARN-6493-branch-2.7.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7494dc9d27ed 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 54bbdb4
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15685/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15685/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 18s branch-2.7 passed +1 compile 0m 24s branch-2.7 passed with JDK v1.8.0_121 +1 compile 0m 28s branch-2.7 passed with JDK v1.7.0_121 +1 checkstyle 0m 32s branch-2.7 passed +1 mvnsite 0m 37s branch-2.7 passed +1 mvneclipse 0m 20s branch-2.7 passed +1 findbugs 1m 11s branch-2.7 passed +1 javadoc 0m 20s branch-2.7 passed with JDK v1.8.0_121 +1 javadoc 0m 23s branch-2.7 passed with JDK v1.7.0_121 +1 mvninstall 0m 28s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_121 +1 javac 0m 23s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_121 +1 javac 0m 26s the patch passed -0 checkstyle 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 824 unchanged - 0 fixed = 825 total (was 824) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1172 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 31s The patch 73 line(s) with tabs. +1 findbugs 1m 14s the patch passed +1 javadoc 0m 16s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_121 -1 unit 50m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 132m 26s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_121 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue YARN-6493 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864178/YARN-6493-branch-2.7.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7494dc9d27ed 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 54bbdb4 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15685/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15685/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15685/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jhung Jonathan Hung added a comment -

        Attached trunk, branch-2.8, branch-2.7 versions, they are slightly different since the FiCaSchedulerNode object was not available the same way between versions.

        Show
        jhung Jonathan Hung added a comment - Attached trunk, branch-2.8, branch-2.7 versions, they are slightly different since the FiCaSchedulerNode object was not available the same way between versions.

          People

          • Assignee:
            jhung Jonathan Hung
            Reporter:
            jhung Jonathan Hung
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development