It would be useful to have the node's partition when logging a container allocation, for tracking purposes.
Attached trunk, branch-2.8, branch-2.7 versions, they are slightly different since the FiCaSchedulerNode object was not available the same way between versions.
This message was automatically generated.
Jonathan Hung, for trunk/branch-2 patch, I suggest to use RMContainer.getNodeLabelExpression. You don't need to read any fields from node. branch-2.7 patch is fine.
Oh, missed that. Good point, thanks Wangda Tan. Attached 002 for this.
Wangda TanA quick question. For non-exclusive labels, RMContainer.getNodeLabelExpression will give correct label to which container is allocated, correct?
Sunil G, no, it will give you the original requested node label expression. It will be useful depends on the use case.
Jonathan Hung, not sure which partition you want to print, requested, or allocated, since non-exclusive node label could give you different partition other than you requested.
I see...seems requested label is most useful, so that we can track demand per partition.
In this case the branch-2.8 patch needs to be changed. Uploaded branch-2.8.002 for this.
Hi Wangda Tan, does the latest patch look OK to you? Thanks!
Thanks Jonathan Hung for updating the patch, could you:
1) Rename "partition" to "requestedPartition"?
2) Could you add a null check for rmcontainer in the 2.8 patch? It should not be expected happe, however I don't want it kills RM by mistake.
Thanks Wangda Tan, uploaded three patches (003 for trunk, 003 for branch-2.8, 002 for branch-2.7).
Also added some logging in branch-2.8 in case allocatedContainer null.
Thanks Jonathan Hung, patch LGTM, +1. Will commit soon.
Committed to trunk/branch-2/branch-2.7/branch-2.8. Thanks Jonathan Hung!
Awesome, thanks Wangda Tan!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11766 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11766/)
YARN-6493. Print requested node partition in assignContainer logs. (wangda: rev 8e0f83e49a8987cf45a72c8a9bb8587b86e4c0ed)
Wangda Tan can you please update the CHANGES.txt in branch-2.7?
Brahma Reddy Battula, thanks for the reminding, just updated.
2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.