Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6477

Dispatcher no longer needs the raw types suppression

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Post YARN-4457, the @SuppressWarnings("rawtypes") is no longer needed in the Dispatcher class.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 15m 8s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 31s trunk passed
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 16s the patch passed
        +1 javadoc 0m 26s the patch passed
        +1 unit 2m 18s hadoop-yarn-common in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        26m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6477
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870170/YARN-6477.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a98fbb7e7e31 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 89bb8bf
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16035/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16035/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16035/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 15m 8s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 16s trunk passed -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 31s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 16s the patch passed +1 javadoc 0m 26s the patch passed +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 26m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6477 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870170/YARN-6477.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a98fbb7e7e31 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 89bb8bf Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16035/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16035/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/16035/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        maya Maya Wexler added a comment -

        The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

        This patch is a removal of an annotation that suppresses a warning, so no new tests are required. With the annotation's removal, there are still no compilation warnings for the Dispatcher interface. I manually ran the unit tests in hadoop-yarn-common and they all passed.

        adoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.

        Unrelated to this patch, as it's a potential NP in a different class (org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogValue)

        Show
        maya Maya Wexler added a comment - The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. This patch is a removal of an annotation that suppresses a warning, so no new tests are required. With the annotation's removal, there are still no compilation warnings for the Dispatcher interface. I manually ran the unit tests in hadoop-yarn-common and they all passed. adoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. Unrelated to this patch, as it's a potential NP in a different class (org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogValue)
        Hide
        haibochen Haibo Chen added a comment -

        +1. Checking this in.

        Show
        haibochen Haibo Chen added a comment - +1. Checking this in.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Maya Wexler for your contribution! I have committed it to trunk.

        Show
        haibochen Haibo Chen added a comment - Thanks Maya Wexler for your contribution! I have committed it to trunk.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11801 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11801/)
        YARN-6477. Dispatcher no longer needs the raw types suppression. (Maya (haibochen: rev 4b4a6524f2df3a891e9d5486ec39f7987766d84f)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/Dispatcher.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11801 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11801/ ) YARN-6477 . Dispatcher no longer needs the raw types suppression. (Maya (haibochen: rev 4b4a6524f2df3a891e9d5486ec39f7987766d84f) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/Dispatcher.java

          People

          • Assignee:
            maya Maya Wexler
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development