[YARN-6450] TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
• Component/s: test
• Assignee: Jason Darrell Lowe
• Reporter: Jason Darrell Lowe
• Created: 05/Apr/17 20:42
• Updated: 21/Jul/17 15:37
• Resolved: 12/Apr/17 15:32

Description

Every test in TestContainerManagerWithLCE looks like this:

  @Override
  public void testSomething() throws Exception {
    // Don't run the test if the binary is not available.
    if (!shouldRunTest()) {
      LOG.info("LCE binary path is not passed. Not running the test");
      return;
    }
    LOG.info("Running something");
    super.testSomething();
  }

If a new test is added to ContainerManagerTest then by default ContainerManagerTestWithLCE will fail when the LCE has not been configured. This is an unnecessary maintenance burden.