Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6450

TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: test
    • Labels:
      None

      Description

      Every test in TestContainerManagerWithLCE looks like this:

        @Override
        public void testSomething() throws Exception {
          // Don't run the test if the binary is not available.
          if (!shouldRunTest()) {
            LOG.info("LCE binary path is not passed. Not running the test");
            return;
          }
          LOG.info("Running something");
          super.testSomething();
        }
      

      If a new test is added to ContainerManagerTest then by default ContainerManagerTestWithLCE will fail when the LCE has not been configured. This is an unnecessary maintenance burden.

        Attachments

          Activity

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: