[YARN-6438] Code can be improved in ContainersMonitorImpl.java

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha4
• Component/s: nodemanager
• Labels: newbie
• Hadoop Flags: Reviewed
• Assignee: Miklos Szegedi
• Reporter: Miklos Szegedi
• Created: 04/Apr/17 20:44
• Updated: 19/Apr/17 18:21
• Resolved: 19/Apr/17 17:57

Description

I noticed two code blocks that can be improved in ContainersMonitorImpl.java. cpuUsagePercentPerCoreByAllContainers and cpuUsageTotalCoresByAllContainers track the same value and CHANGE_MONITORING_CONTAINER_RESOURCE is checked twice along with two calls to changeContainerResource.