Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6436

TestSchedulingPolicy#testParseSchedulingPolicy timeout is too low

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The timeout for testParseSchedulingPolicy is only one second. An I/O hiccup on a VM can make this test fail for the wrong reasons.

      1. YARN-6436.001.patch
        1 kB
        Eric Badger
      2. YARN-6436.002.patch
        1 kB
        Eric Badger

        Activity

        Hide
        ebadger Eric Badger added a comment -

        Updating timeout to 30 seconds

        Show
        ebadger Eric Badger added a comment - Updating timeout to 30 seconds
        Hide
        jlowe Jason Lowe added a comment -

        Do we even need a timeout for this test?

        Show
        jlowe Jason Lowe added a comment - Do we even need a timeout for this test?
        Hide
        ebadger Eric Badger added a comment -

        Getting rid of the timeout

        Show
        ebadger Eric Badger added a comment - Getting rid of the timeout
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 29s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 41s trunk passed
        +1 compile 0m 31s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 56s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 28s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 28s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 0s the patch passed
        +1 javadoc 0m 17s the patch passed
        +1 unit 40m 26s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        61m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6436
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861934/YARN-6436.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux edc39a6a6de7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 56ab02e
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15508/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15508/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 41s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 28s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 40m 26s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 61m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6436 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861934/YARN-6436.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux edc39a6a6de7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 56ab02e Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15508/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15508/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1, checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1, checking this in.
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks Eric for the patch. Just committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - Thanks Eric for the patch. Just committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11523 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11523/)
        YARN-6436. TestSchedulingPolicy#testParseSchedulingPolicy timeout is too (kasha: rev 9cc04b4708879012da1f9ef690679d8d1e45c0cc)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11523 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11523/ ) YARN-6436 . TestSchedulingPolicy#testParseSchedulingPolicy timeout is too (kasha: rev 9cc04b4708879012da1f9ef690679d8d1e45c0cc) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java
        Hide
        jlowe Jason Lowe added a comment -

        I committed this to branch-2.8 as well.

        Show
        jlowe Jason Lowe added a comment - I committed this to branch-2.8 as well.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
        YARN-6436. TestSchedulingPolicy#testParseSchedulingPolicy timeout is too (kasha: rev 9cc04b4708879012da1f9ef690679d8d1e45c0cc)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) YARN-6436 . TestSchedulingPolicy#testParseSchedulingPolicy timeout is too (kasha: rev 9cc04b4708879012da1f9ef690679d8d1e45c0cc) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          People

          • Assignee:
            ebadger Eric Badger
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development