Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6381

FSAppAttempt has several variables that should be final

    Details

    • Hadoop Flags:
      Reviewed

      Description

      These should all be final:

        private long startTime;
        private Priority appPriority;
        private ResourceWeights resourceWeights;
        private FairScheduler scheduler;
        private Map<String, Set<String>> reservations = new HashMap<>();
        private List<FSSchedulerNode> blacklistNodeIds = new ArrayList<>();
      

        Activity

        Hide
        templedf Daniel Templeton added a comment -

        LGTM +1 I'll commit in a bit.

        Show
        templedf Daniel Templeton added a comment - LGTM +1 I'll commit in a bit.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 31s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 42s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 26s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 37s the patch passed
        +1 javac 0m 37s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 0m 40s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 24s the patch passed
        +1 unit 42m 12s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        65m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6381
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861796/YARN-6381.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8e3ccc690e15 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 87e2ef8
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15532/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15532/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 31s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 42s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 26s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 0m 37s the patch passed +1 javac 0m 37s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 24s the patch passed +1 unit 42m 12s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 65m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6381 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861796/YARN-6381.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e3ccc690e15 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 87e2ef8 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15532/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/15532/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11536 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11536/)
        YARN-6381. FSAppAttempt has several variables that should be final (templedf: rev a2c57bb70d719f72d59413f33ae67781b583b9f8)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11536 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11536/ ) YARN-6381 . FSAppAttempt has several variables that should be final (templedf: rev a2c57bb70d719f72d59413f33ae67781b583b9f8) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Ameet Zaveri! Committed to trunk and branch-2.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Ameet Zaveri ! Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
        YARN-6381. FSAppAttempt has several variables that should be final (templedf: rev a2c57bb70d719f72d59413f33ae67781b583b9f8)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) YARN-6381 . FSAppAttempt has several variables that should be final (templedf: rev a2c57bb70d719f72d59413f33ae67781b583b9f8) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java

          People

          • Assignee:
            ameetz Ameet Zaveri
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development