Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6352

Header injections are possible in application proxy servlet

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.3
    • Fix Version/s: 2.9.0, 2.8.2
    • Component/s: resourcemanager, security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This issue was found in WVS security tool.

      1. headerInjection.png
        136 kB
        Naganarasimha G R
      2. YARN-6352.001.patch
        2 kB
        Naganarasimha G R
      3. YARN-6352-branch-2.002.patch
        4 kB
        Naganarasimha G R
      4. YARN-6352-branch-2.003.patch
        4 kB
        Naganarasimha G R

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 12m 58s root in trunk failed.
        +1 compile 0m 26s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 54s trunk passed
        +1 javadoc 0m 27s trunk passed
        +1 mvninstall 0m 25s the patch passed
        +1 compile 0m 25s the patch passed
        +1 javac 0m 25s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 2s the patch passed
        +1 javadoc 0m 24s the patch passed
        +1 unit 2m 22s hadoop-yarn-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        23m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6352
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859146/YARN-6352.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b2ebd85ea616 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ba62b50
        Default Java 1.8.0_121
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15302/artifact/patchprocess/branch-mvninstall-root.txt
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15302/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15302/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 12m 58s root in trunk failed. +1 compile 0m 26s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 25s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 2s the patch passed +1 javadoc 0m 24s the patch passed +1 unit 2m 22s hadoop-yarn-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 23m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6352 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859146/YARN-6352.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b2ebd85ea616 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ba62b50 Default Java 1.8.0_121 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15302/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15302/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/15302/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment - - edited

        Apps#toAppId looks like a generic enough method which may not be only used for constructing a message which is sent back in HTTP response.
        How about catching the exception in WebAppProxyServlet and then sending back a custom message?

        Show
        varun_saxena Varun Saxena added a comment - - edited Apps#toAppId looks like a generic enough method which may not be only used for constructing a message which is sent back in HTTP response. How about catching the exception in WebAppProxyServlet and then sending back a custom message?
        Hide
        varun_saxena Varun Saxena added a comment -

        Naganarasimha G R, did you try with latest trunk code?
        This issue does not seem to come after Jetty was upgraded to version 9 from previous version 6.
        Seems this vulnerability has been fixed in Jetty in some version between 6.1.26 to 9.3.11.

        Show
        varun_saxena Varun Saxena added a comment - Naganarasimha G R , did you try with latest trunk code? This issue does not seem to come after Jetty was upgraded to version 9 from previous version 6. Seems this vulnerability has been fixed in Jetty in some version between 6.1.26 to 9.3.11.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Varun Saxena,

        Apps#toAppId looks like a generic enough method which may not be only used for constructing a message which is sent back in HTTP response. How about catching the exception in WebAppProxyServlet and then sending back a custom message?

        Had checked Apps#toAppId earlier, as it was not used else where did the modifications(and where ever used they had handled YarnRuntimeException). but agree it would be better handled in WebAppProxyServlet.

        This issue does not seem to come after Jetty was upgraded to version 9 from previous version 6.

        Seems this vulnerability has been fixed in Jetty in some version between 6.1.26 to 9.3.11.
        Thanks for testing and confirming, earlier had tested with 2.8 RC2. Tested with the trunk and was not able to reproduce. have updated the target versions

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Varun Saxena , Apps#toAppId looks like a generic enough method which may not be only used for constructing a message which is sent back in HTTP response. How about catching the exception in WebAppProxyServlet and then sending back a custom message? Had checked Apps#toAppId earlier, as it was not used else where did the modifications(and where ever used they had handled YarnRuntimeException). but agree it would be better handled in WebAppProxyServlet. This issue does not seem to come after Jetty was upgraded to version 9 from previous version 6. Seems this vulnerability has been fixed in Jetty in some version between 6.1.26 to 9.3.11. Thanks for testing and confirming, earlier had tested with 2.8 RC2. Tested with the trunk and was not able to reproduce. have updated the target versions
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 31s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 46s branch-2 passed
        +1 compile 0m 15s branch-2 passed with JDK v1.8.0_121
        +1 compile 0m 17s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 15s branch-2 passed
        +1 mvnsite 0m 23s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 0m 31s branch-2 passed
        +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 14s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.8.0_121
        +1 javac 0m 11s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.7.0_121
        +1 javac 0m 13s the patch passed
        -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy: The patch generated 1 new + 63 unchanged - 0 fixed = 64 total (was 63)
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 0m 36s the patch passed
        +1 javadoc 0m 8s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 11s the patch passed with JDK v1.7.0_121
        +1 unit 0m 24s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        15m 51s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6352
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860263/YARN-6352-branch-2.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 36af1cf0797c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / d946dfc
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15370/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15370/artifact/patchprocess/whitespace-eol.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15370/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15370/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 46s branch-2 passed +1 compile 0m 15s branch-2 passed with JDK v1.8.0_121 +1 compile 0m 17s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 15s branch-2 passed +1 mvnsite 0m 23s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 0m 31s branch-2 passed +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 14s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_121 +1 javac 0m 11s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_121 +1 javac 0m 13s the patch passed -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy: The patch generated 1 new + 63 unchanged - 0 fixed = 64 total (was 63) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 0m 36s the patch passed +1 javadoc 0m 8s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_121 +1 unit 0m 24s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 15m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6352 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860263/YARN-6352-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 36af1cf0797c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / d946dfc Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15370/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15370/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15370/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15370/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Naganarasimha G R for the patch.
        Couple of nits.

        1. There is a commented line in WebAppProxyServlet. That should be removed.
        2. Checkstyle issue in test case can be fixed as well
        Show
        varun_saxena Varun Saxena added a comment - Thanks Naganarasimha G R for the patch. Couple of nits. There is a commented line in WebAppProxyServlet. That should be removed. Checkstyle issue in test case can be fixed as well
        Hide
        Naganarasimha Naganarasimha G R added a comment - - edited

        Thanks Varun Saxena, i have uploaded a patch with the corrections you mentioned

        Show
        Naganarasimha Naganarasimha G R added a comment - - edited Thanks Varun Saxena , i have uploaded a patch with the corrections you mentioned
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 55s branch-2 passed
        +1 compile 0m 13s branch-2 passed with JDK v1.8.0_121
        +1 compile 0m 18s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 13s branch-2 passed
        +1 mvnsite 0m 21s branch-2 passed
        +1 mvneclipse 0m 13s branch-2 passed
        +1 findbugs 0m 29s branch-2 passed
        +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 14s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.8.0_121
        +1 javac 0m 11s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.7.0_121
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 36s the patch passed
        +1 javadoc 0m 9s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 12s the patch passed with JDK v1.7.0_121
        +1 unit 0m 26s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        14m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6352
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860420/YARN-6352-branch-2.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c30284be9fcc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / bbd08bb
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15378/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15378/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 55s branch-2 passed +1 compile 0m 13s branch-2 passed with JDK v1.8.0_121 +1 compile 0m 18s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 13s branch-2 passed +1 mvnsite 0m 21s branch-2 passed +1 mvneclipse 0m 13s branch-2 passed +1 findbugs 0m 29s branch-2 passed +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 14s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_121 +1 javac 0m 11s the patch passed +1 compile 0m 14s the patch passed with JDK v1.7.0_121 +1 javac 0m 14s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_121 +1 unit 0m 26s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 14m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6352 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860420/YARN-6352-branch-2.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c30284be9fcc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / bbd08bb Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15378/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15378/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Varun Saxena, can you take a look at the final patch ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Varun Saxena , can you take a look at the final patch ?
        Hide
        varun_saxena Varun Saxena added a comment -

        Will have a look today.

        Show
        varun_saxena Varun Saxena added a comment - Will have a look today.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Naganarasimha G R for the patch.
        LGTM.
        I will wait for a day before committing unless there are opposite opinions.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Naganarasimha G R for the patch. LGTM. I will wait for a day before committing unless there are opposite opinions.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 1m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 15s branch-2 passed
        +1 compile 0m 16s branch-2 passed with JDK v1.8.0_121
        +1 compile 0m 16s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 14s branch-2 passed
        +1 mvnsite 0m 21s branch-2 passed
        +1 mvneclipse 0m 13s branch-2 passed
        +1 findbugs 0m 30s branch-2 passed
        +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 13s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.8.0_121
        +1 javac 0m 11s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.7.0_121
        +1 javac 0m 13s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 17s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 36s the patch passed
        +1 javadoc 0m 9s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 11s the patch passed with JDK v1.7.0_121
        +1 unit 0m 25s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        16m 10s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue YARN-6352
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860420/YARN-6352-branch-2.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bc5a15bafcad 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 97c83f2
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15408/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15408/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 1m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 15s branch-2 passed +1 compile 0m 16s branch-2 passed with JDK v1.8.0_121 +1 compile 0m 16s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 14s branch-2 passed +1 mvnsite 0m 21s branch-2 passed +1 mvneclipse 0m 13s branch-2 passed +1 findbugs 0m 30s branch-2 passed +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 13s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 15s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_121 +1 javac 0m 11s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_121 +1 javac 0m 13s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_121 +1 unit 0m 25s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 16m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue YARN-6352 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860420/YARN-6352-branch-2.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc5a15bafcad 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 97c83f2 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15408/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15408/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to branch-2 and branch-2.8
        Thanks Naganarasimha G R for your contribution

        Show
        varun_saxena Varun Saxena added a comment - Committed to branch-2 and branch-2.8 Thanks Naganarasimha G R for your contribution
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          People

          • Assignee:
            Naganarasimha Naganarasimha G R
            Reporter:
            Naganarasimha Naganarasimha G R
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development